Review main Merged

71446[BUGFIX] Add absRefPrefix on cached pages with uncached content

Robert Kärner CR +2 V +2 Easy +7 −0 updated 10/06/21, 14:04

Commit message

PublicUrlPrefixer must also generate absolute FAL URLs
if a page is cached but has uncached content.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Helmut Hummel +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Robert Kärner uploaded patch set 1 10/05/21, 15:36

  2. Robert Kärner commented on patch set 1 10/05/21, 15:41

    RequestHandler.php:156

    Since this is duplicated code, it might make sense to move it above line 123 and remove the duplicate at line 129. However, I think this is the more performant way, as the listener is only added when needed.
  3. core-ci voted on patch set 1 V +1 10/05/21, 15:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17625

  4. Helmut Hummel commented on patch set 1 V +1 CR +1 10/06/21, 13:56

    RequestHandler.php:156 Reply

    I think it's fine to add this twice. Good catch btw.
  5. Georg Ringer voted on patch set 1 V +2 CR +2 10/06/21, 14:04

  6. Georg Ringer merged patch set 2 10/06/21, 14:04