71449[BUGFIX] Add parenthesis where operation result is enforced
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php2+1 −1
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+1 −1
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+2 −2
- typo3/sysext/impexp/Classes/Export.php+1 −1
- typo3/sysext/install/Classes/Updates/BackendUserLanguageMigration.php+1 −1
Review log 1011
-
Nikita Hovratov uploaded patch set 1 10/05/21, 20:22
-
core-ci voted on patch set 1 V +1 10/05/21, 20:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17635
-
Benjamin Franzke voted on patch set 1 CR +1 10/06/21, 03:11
-
Benjamin Franzke voted on patch set 1 V +1 10/06/21, 03:39
-
Oli Bartsch commented on patch set 1 10/08/21, 22:07
ContentObjectRenderer.php:3425This is already fixed. (See #95489) -
Oli Bartsch commented on patch set 1 V +2 CR +2 10/08/21, 22:11
Typo3DbBackend.php:503ReplyDoneContentObjectRenderer.php:3425ReplyDone -
Oli Bartsch merged patch set 2 10/08/21, 22:11
-
Oliver Hader commented on patch set 2 05/04/22, 06:42
What about back-porting this to 10.4 branch (as mentioned in `Releases:`)? -
Oli Bartsch commented on patch set 2 05/04/22, 14:01
Reply
Unfortunately this backport was forgotten. We noticed it when 10.4 was already in priority bugfix mode and we therefore decided to not do the backport anymore. -
Oliver Klee commented on patch set 2 05/04/22, 14:06
Reply
Should/can we backport this to 11.5? -
Oliver Hader commented on patch set 2 05/04/22, 16:11
Reply
It is part of v11.5.1 - at that time the branch for `11.5` did not exist yet. I've excluded the back-port now at https://forger.typo3.com/utilities/backport/list
Typo3DbBackend.php:503