Review main Merged

71452[FEATURE] Add "accept" as UploadViewHelper argument

Henrik Elsner CR +2 V +2 Easy +36 −0 updated 11/29/21, 17:01

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2235

Show 610 earlier messages
  1. Henrik Elsner uploaded patch set 1 10/06/21, 07:02

  2. Henrik Elsner uploaded patch set 2 10/06/21, 07:05

  3. Henrik Elsner updated the commit message in patch set 3 10/06/21, 07:05

  4. Oli Bartsch commented on patch set 3 10/06/21, 07:14

    Please just "master, 10.4". We didn't branch yet.
  5. Henrik Elsner updated the commit message in patch set 4 10/06/21, 07:24

  6. core-ci voted on patch set 2 V -1 10/06/21, 07:25 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17644

  7. core-ci voted on patch set 1 V -1 10/06/21, 07:26 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17643

  8. core-ci voted on patch set 3 V -1 10/06/21, 07:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17645

  9. core-ci voted on patch set 4 V -1 10/06/21, 07:41 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17647

  10. Henrik Elsner uploaded patch set 5 10/06/21, 08:23

  1. core-ci voted on patch set 5 V +1 10/06/21, 08:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17652

  2. Georg Ringer commented on patch set 5 V -1 CR +1 10/06/21, 14:06

    sorry but this is a feature, 12 only. this can be easily solved with additionalAttributes
  3. Guido Schmechel commented on patch set 5 11/01/21, 18:05

    And also a RST with the hints from https://www.w3schools.com/TAGS/att_input_accept.asp would be super. So that the user knows which formats are allowed.
  4. Henrik Elsner updated the commit message in patch set 6 11/02/21, 07:13

  5. Henrik Elsner updated the commit message in patch set 7 11/02/21, 07:17

  6. core-ci voted on patch set 6 V +1 11/02/21, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18736

  7. core-ci voted on patch set 7 V +1 11/02/21, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18737

  8. Anja Leichsenring commented on patch set 7 V -1 11/03/21, 14:13

    TYPO3 v12 only, because FEAT -> and it should read feature and requires a feature.rst
  9. Benni Mack commented on patch set 7 11/27/21, 13:22

    Ping. We can now continue with this...
  10. Henrik Elsner commented on patch set 7 11/27/21, 13:59

    Reply

    will do!
  11. Henrik Elsner uploaded patch set 8 11/27/21, 14:06

  12. core-ci voted on patch set 8 V +1 11/27/21, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19865

  13. Christian Kuhn commented on patch set 8 CR -1 11/27/21, 16:44

    details ;)
    [FEATURE]

    Feature-95486-AddAcceptArgument.rst:5

    "=" should be same nummer of chars as the title.

    Feature-95486-AddAcceptArgument.rst:25

    imho: .. index:: Fluid, ext:fluid
  14. Christian Kuhn commented on patch set 8 11/27/21, 20:29

    Reply

    Done

    Reply

    Done

    Feature-95486-AddAcceptArgument.rst:5 Reply

    Done

    Feature-95486-AddAcceptArgument.rst:25 Reply

    Done
  15. Christian Kuhn uploaded patch set 9 11/27/21, 20:29

  16. Christian Kuhn uploaded patch set 10 11/27/21, 20:31

  17. core-ci voted on patch set 9 V +1 11/27/21, 20:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19895

  18. core-ci voted on patch set 10 V -1 11/27/21, 21:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19897

  19. core-ci commented on patch set 10 11/27/21, 21:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19897

  20. core-ci commented on patch set 10 11/27/21, 22:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19897

  21. core-ci voted on patch set 10 V +1 11/27/21, 22:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19897

  22. Christian Kuhn voted on patch set 10 V +2 CR +2 11/27/21, 23:00

  23. Stefan Bürk voted on patch set 10 V +1 CR +1 11/27/21, 23:01

  24. Christian Kuhn merged patch set 11 11/27/21, 23:01

  25. Oli Bartsch commented on patch set 11 11/29/21, 17:01

    This introduced a regression, see https://forge.typo3.org/issues/96146.