71452[FEATURE] Add "accept" as UploadViewHelper argument
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 3
Review log 2235
Show 610 earlier messages
-
Henrik Elsner uploaded patch set 1 10/06/21, 07:02
-
Henrik Elsner uploaded patch set 2 10/06/21, 07:05
-
Henrik Elsner updated the commit message in patch set 3 10/06/21, 07:05
-
Oli Bartsch commented on patch set 3 10/06/21, 07:14
Please just "master, 10.4". We didn't branch yet. -
Henrik Elsner updated the commit message in patch set 4 10/06/21, 07:24
-
core-ci voted on patch set 2 V -1 10/06/21, 07:25 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17644
-
core-ci voted on patch set 1 V -1 10/06/21, 07:26 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17643
-
core-ci voted on patch set 3 V -1 10/06/21, 07:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17645
-
core-ci voted on patch set 4 V -1 10/06/21, 07:41 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17647
-
Henrik Elsner uploaded patch set 5 10/06/21, 08:23
-
core-ci voted on patch set 5 V +1 10/06/21, 08:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17652
-
Georg Ringer commented on patch set 5 V -1 CR +1 10/06/21, 14:06
sorry but this is a feature, 12 only. this can be easily solved with additionalAttributes -
Guido Schmechel commented on patch set 5 11/01/21, 18:05
And also a RST with the hints from https://www.w3schools.com/TAGS/att_input_accept.asp would be super. So that the user knows which formats are allowed. -
Henrik Elsner updated the commit message in patch set 6 11/02/21, 07:13
-
Henrik Elsner updated the commit message in patch set 7 11/02/21, 07:17
-
core-ci voted on patch set 6 V +1 11/02/21, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18736
-
core-ci voted on patch set 7 V +1 11/02/21, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18737
-
Anja Leichsenring commented on patch set 7 V -1 11/03/21, 14:13
TYPO3 v12 only, because FEAT -> and it should read feature and requires a feature.rst -
Benni Mack commented on patch set 7 11/27/21, 13:22
Ping. We can now continue with this... -
Henrik Elsner commented on patch set 7 11/27/21, 13:59
Reply
will do! -
Henrik Elsner uploaded patch set 8 11/27/21, 14:06
-
core-ci voted on patch set 8 V +1 11/27/21, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19865
-
Christian Kuhn commented on patch set 8 CR -1 11/27/21, 16:44
details ;)[FEATURE]Feature-95486-AddAcceptArgument.rst:5"=" should be same nummer of chars as the title.Feature-95486-AddAcceptArgument.rst:25imho: .. index:: Fluid, ext:fluid -
Christian Kuhn commented on patch set 8 11/27/21, 20:29
Reply
DoneReply
DoneFeature-95486-AddAcceptArgument.rst:5ReplyDoneFeature-95486-AddAcceptArgument.rst:25ReplyDone -
Christian Kuhn uploaded patch set 9 11/27/21, 20:29
-
Christian Kuhn uploaded patch set 10 11/27/21, 20:31
-
core-ci voted on patch set 9 V +1 11/27/21, 20:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19895
-
core-ci voted on patch set 10 V -1 11/27/21, 21:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19897
-
core-ci commented on patch set 10 11/27/21, 21:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19897
-
core-ci commented on patch set 10 11/27/21, 22:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19897
-
core-ci voted on patch set 10 V +1 11/27/21, 22:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19897
-
Christian Kuhn voted on patch set 10 V +2 CR +2 11/27/21, 23:00
-
Stefan Bürk voted on patch set 10 V +1 CR +1 11/27/21, 23:01
-
Christian Kuhn merged patch set 11 11/27/21, 23:01
-
Oli Bartsch commented on patch set 11 11/29/21, 17:01
This introduced a regression, see https://forge.typo3.org/issues/96146.