Review main Merged

71453[BUGFIX] Fix some minor Composer mode path inconsistencies

Helmut Hummel CR +2 V +2 Easy +13 −21 updated 10/11/21, 08:17

Commit message

* Use config API instead of env vars when building package artifact
* Don't try to scan for extensions in Composer mode
* Don't create extension directory in Composer mode, as
  the composer installer takes care of creating it if needed
* Don't try to scan extension directory if it does not exist
* Use package type instead of install path to distinguish core extensions

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
    • Simon Gilli +1
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Oli Bartsch +1
    • Simon Gilli +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 89

  1. Helmut Hummel uploaded patch set 1 10/06/21, 07:29

  2. core-ci voted on patch set 1 V +1 10/06/21, 07:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17648

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 10/06/21, 10:18

  4. Benjamin Franzke voted on patch set 1 CR +1 10/06/21, 12:49

  5. Oliver Hader voted on patch set 1 CR +1 10/06/21, 13:33

  6. Simon Gilli voted on patch set 1 V +1 CR +1 10/10/21, 16:16

  7. Benni Mack voted on patch set 1 CR +1 10/10/21, 18:25

  8. Helmut Hummel voted on patch set 1 V +2 CR +2 10/11/21, 08:17

  9. Helmut Hummel merged patch set 2 10/11/21, 08:17