71455[BUGFIX] Fix undefined array key errors for PHP 8.0
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Jochen Roth +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2127
Show 12 earlier messages
-
core-ci voted on patch set 1 V -1 10/06/21, 08:35 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17653
-
Nikita Hovratov uploaded patch set 2 10/07/21, 09:08
-
Nikita Hovratov commented on patch set 1 10/07/21, 09:08
AbstractMenuContentObject.php:1116ReplyDoneFileOrFolderLinkBuilder.php:34ReplyDoneDeletedRecords.php:249ReplyDone -
core-ci voted on patch set 2 V +1 10/07/21, 09:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17723
-
Oliver Klee voted on patch set 2 CR +1 10/07/21, 09:29
-
Stefan Bürk uploaded patch set 3 10/10/21, 12:40
-
Nikita Hovratov commented on patch set 3 10/10/21, 12:45
FileOrFolderLinkBuilder.php:35Parenthesis are not needed here. -
core-ci voted on patch set 3 V -1 10/10/21, 12:45 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17893
-
Stefan Bürk commented on patch set 3 10/10/21, 12:47
FileOrFolderLinkBuilder.php:35ReplyTechnical not (for now), but makes it easier to read/understand the order. But will change it back. -
Stefan Bürk uploaded patch set 4 10/10/21, 12:48
-
Stefan Bürk commented on patch set 4 10/10/21, 12:48
FileOrFolderLinkBuilder.php:35ReplyDone -
Oliver Klee voted on patch set 4 CR +1 10/10/21, 12:56
-
core-ci voted on patch set 4 V +1 10/10/21, 13:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17894
-
Stefan Bürk voted on patch set 4 V +1 CR +1 10/10/21, 13:06
-
Nikita Hovratov commented on patch set 4 CR -1 10/10/21, 13:20
I'll add a few more -
Nikita Hovratov uploaded patch set 5 10/10/21, 13:43
-
core-ci voted on patch set 5 V +1 10/10/21, 13:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17895
-
Oliver Klee voted on patch set 5 CR +1 10/10/21, 14:05
-
Stefan Bürk voted on patch set 5 CR +1 10/10/21, 17:43
-
Simon Schaufelberger commented on patch set 5 10/11/21, 10:59
I have some more. Should I just add those to this patch? -
Jochen Roth voted on patch set 5 V +1 CR +1 10/11/21, 11:05
-
Stefan Bürk voted on patch set 5 V +1 10/11/21, 11:06
-
Christian Kuhn commented on patch set 5 10/11/21, 11:44
Reply
No. Please keep these patches small. Single issues / patches per case. I don't like that an ext:recycler is mixed into this ext:frontented patch, too, but will accept it for now. -
Christian Kuhn voted on patch set 5 V +2 CR +2 10/11/21, 11:50
-
Christian Kuhn merged patch set 6 10/11/21, 11:50
AbstractMenuContentObject.php:1116