Review main Merged

71455[BUGFIX] Fix undefined array key errors for PHP 8.0

TYPO3com CR +2 V +2 Easy +19 −22 updated 10/11/21, 11:50

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2127

Show 12 earlier messages
  1. TYPO3com uploaded patch set 1 10/06/21, 08:31

  2. Benjamin Franzke commented on patch set 1 CR -1 10/06/21, 08:34

    AbstractMenuContentObject.php:1116

    ''

    FileOrFolderLinkBuilder.php:34

    Missing parentheses: ($linkDetails['file'] ?? false) ?:

    DeletedRecords.php:249

    ''
  1. core-ci voted on patch set 1 V -1 10/06/21, 08:35 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17653

  2. Nikita Hovratov uploaded patch set 2 10/07/21, 09:08

  3. Nikita Hovratov commented on patch set 1 10/07/21, 09:08

    AbstractMenuContentObject.php:1116 Reply

    Done

    FileOrFolderLinkBuilder.php:34 Reply

    Done

    DeletedRecords.php:249 Reply

    Done
  4. core-ci voted on patch set 2 V +1 10/07/21, 09:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17723

  5. Oliver Klee voted on patch set 2 CR +1 10/07/21, 09:29

  6. Stefan Bürk uploaded patch set 3 10/10/21, 12:40

  7. Nikita Hovratov commented on patch set 3 10/10/21, 12:45

    FileOrFolderLinkBuilder.php:35

    Parenthesis are not needed here.
  8. core-ci voted on patch set 3 V -1 10/10/21, 12:45 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17893

  9. Stefan Bürk commented on patch set 3 10/10/21, 12:47

    FileOrFolderLinkBuilder.php:35 Reply

    Technical not (for now), but makes it easier to read/understand the order. But will change it back.
  10. Stefan Bürk uploaded patch set 4 10/10/21, 12:48

  11. Stefan Bürk commented on patch set 4 10/10/21, 12:48

    FileOrFolderLinkBuilder.php:35 Reply

    Done
  12. Oliver Klee voted on patch set 4 CR +1 10/10/21, 12:56

  13. core-ci voted on patch set 4 V +1 10/10/21, 13:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17894

  14. Stefan Bürk voted on patch set 4 V +1 CR +1 10/10/21, 13:06

  15. Nikita Hovratov commented on patch set 4 CR -1 10/10/21, 13:20

    I'll add a few more
  16. Nikita Hovratov uploaded patch set 5 10/10/21, 13:43

  17. core-ci voted on patch set 5 V +1 10/10/21, 13:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17895

  18. Oliver Klee voted on patch set 5 CR +1 10/10/21, 14:05

  19. Stefan Bürk voted on patch set 5 CR +1 10/10/21, 17:43

  20. Simon Schaufelberger commented on patch set 5 10/11/21, 10:59

    I have some more. Should I just add those to this patch?
  21. Jochen Roth voted on patch set 5 V +1 CR +1 10/11/21, 11:05

  22. Stefan Bürk voted on patch set 5 V +1 10/11/21, 11:06

  23. Christian Kuhn commented on patch set 5 10/11/21, 11:44

    Reply

    No. Please keep these patches small. Single issues / patches per case. I don't like that an ext:recycler is mixed into this ext:frontented patch, too, but will accept it for now.
  24. Christian Kuhn voted on patch set 5 V +2 CR +2 10/11/21, 11:50

  25. Christian Kuhn merged patch set 6 10/11/21, 11:50