Review main Abandoned

71456[BUGFIX] Check if extension path is public in FilePathSanitizer

Nikita Hovratov CR 0 V 0 Easy +1 −1 updated 10/06/21, 09:50

Commit message

It should be possible to provide private extension paths in
FilePathSanitizer->sanitize. A check is added before calling
PathUtility::getPublicResourceWebPath to ensure the path is indeed
public.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 4

  1. Nikita Hovratov uploaded patch set 1 10/06/21, 09:43

  2. Helmut Hummel commented on patch set 1 CR -2 10/06/21, 09:47

    This won't help unfortunately, as the assumption of this API is to return a path relative to the document root, which does not exist when a path from not public resources is provided. therefore this API must not be used in such case
  3. Helmut Hummel commented on patch set 1 10/06/21, 09:48

  4. Nikita Hovratov abandoned the change 10/06/21, 09:50