71457[BUGFIX] Allow FilePathSanitizer to return absolute paths
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Oli Bartsch +1
- core-ci +1 CI
Issues 2
Files 6
- typo3/sysext/core/Tests/Unit/Page/PageRendererTest.php+2 −8
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+1 −1
- typo3/sysext/frontend/Classes/Http/RequestHandler.php7+7 −7
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php+1 −2
- typo3/sysext/frontend/Classes/Resource/FilePathSanitizer.php+30 −11
- typo3/sysext/frontend/Tests/Unit/Resource/FilePathSanitizerTest.php+84 −2
Review log 3140
Show 1215 earlier messages
-
Helmut Hummel uploaded patch set 1 10/06/21, 09:45
-
Nikita Hovratov commented on patch set 1 10/06/21, 09:57
-
core-ci voted on patch set 1 V +1 10/06/21, 10:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17656
-
Chris Müller commented on patch set 1 10/06/21, 10:09
RequestHandler.php:244ReplyWith applied patch and file does not exists I am getting an empty page, no exception. I would instead prefer a thrown exception with a clear message, so as a developer I know what is going on. -
Helmut Hummel commented on patch set 1 10/06/21, 10:15
RequestHandler.php:244ReplyI'd rather throw an exception in PageRenderer, which currently silently returns an empty string if template file is not found -
Helmut Hummel uploaded patch set 2 10/06/21, 10:19
-
Helmut Hummel commented on patch set 2 10/06/21, 10:20
RequestHandler.php:244ReplyDone -
Chris Müller voted on patch set 2 V +1 CR +1 10/06/21, 10:38
-
core-ci voted on patch set 2 V -1 10/06/21, 10:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17658
-
Helmut Hummel uploaded patch set 3 10/06/21, 13:41
-
core-ci voted on patch set 3 V +1 10/06/21, 14:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17668
-
Chris Müller voted on patch set 3 V +1 CR +1 10/06/21, 14:16
-
Christian Kuhn commented on patch set 3 10/06/21, 16:31
RequestHandler.php:246in case this patch is pushed for a different reason again: please use @todo ... this is easier to grep later. -
Nikita Hovratov uploaded patch set 4 10/07/21, 07:20
-
Nikita Hovratov commented on patch set 4 10/07/21, 07:20
RequestHandler.php:246ReplyDone
-
core-ci voted on patch set 4 V -1 10/07/21, 07:24 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17717
-
Nikita Hovratov uploaded patch set 5 10/07/21, 07:34
-
core-ci voted on patch set 5 V +1 10/07/21, 07:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17718
-
Chris Müller voted on patch set 5 V +1 CR +1 10/07/21, 08:01
-
Nikita Hovratov voted on patch set 5 V +1 CR +1 10/07/21, 08:08
-
Benni Mack commented on patch set 5 10/07/21, 10:26
FYI - I had an interesting (other) use for this area: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62318/3/typo3/sysext/core/Classes/Page/PageRenderer.php -
Helmut Hummel commented on patch set 5 CR -1 10/07/21, 13:25
Benni will comment on this one later -
Helmut Hummel uploaded patch set 6 10/08/21, 07:17
-
Helmut Hummel uploaded patch set 7 10/08/21, 07:18
-
core-ci voted on patch set 6 V -1 10/08/21, 07:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17793
-
Helmut Hummel commented on patch set 7 10/08/21, 07:25
RequestHandler.php:244Reply> With applied patch and file does not exists I am getting an empty page, no exception. I would instead prefer a thrown exception with a clear message, so as a developer I know what is going on. In the latest patch set the previous behaviour is restored, where an invalid file will use the default template -
core-ci voted on patch set 7 V +1 10/08/21, 07:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17794
-
Georg Ringer voted on patch set 7 V +1 CR +1 10/08/21, 07:47
-
Helmut Hummel uploaded patch set 8 10/08/21, 07:57
-
Tymoteusz Motylewski commented on patch set 8 10/08/21, 08:13
is now relaxed -
core-ci voted on patch set 8 V +1 10/08/21, 08:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17795
-
Georg Ringer updated the commit message in patch set 9 10/08/21, 08:17
-
Georg Ringer voted on patch set 9 V +1 CR +1 10/08/21, 08:17
-
core-ci voted on patch set 9 V +1 10/08/21, 08:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17800
-
Benni Mack voted on patch set 9 CR +2 10/08/21, 10:56
-
Helmut Hummel commented on patch set 9 10/08/21, 12:50
Reply
Done -
Oli Bartsch voted on patch set 9 CR +1 10/11/21, 11:52
-
Oli Bartsch voted on patch set 9 V +1 10/11/21, 11:59
-
Benni Mack voted on patch set 9 V +2 10/11/21, 14:51
-
Benni Mack merged patch set 10 10/11/21, 14:51
RequestHandler.php:244