Review main Merged

71459[BUGFIX] Fix displaying issue of buttons inside form fields

Nikita Hovratov CR +2 V +2 Easy +6 −1 updated 11/23/21, 09:02

Commit message

By setting the display property of buttons inside of input-groups to
"flex", the height of the element inside the button can be easier
controlled.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2025

  1. Nikita Hovratov uploaded patch set 1 10/06/21, 10:58

  2. core-ci voted on patch set 1 V +1 10/06/21, 11:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17660

  3. Oli Bartsch commented on patch set 1 V +1 CR +1 10/06/21, 12:46

    While I can't reproduce the bug, the patch seems to do no harm. Therefore fine for me.
  4. Nikita Hovratov uploaded patch set 2 10/06/21, 16:31

  5. core-ci voted on patch set 2 V +1 10/06/21, 16:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17686

  6. Benni Mack commented on patch set 2 10/11/21, 18:15

    I thought this was fixed by updating bootstrap to 5.1.3 https://github.com/twbs/bootstrap/releases
  7. Nikita Hovratov commented on patch set 2 10/11/21, 18:21

    Reply

    Will have a look.
  8. Nikita Hovratov uploaded patch set 3 11/04/21, 17:04

  9. Nikita Hovratov commented on patch set 3 11/04/21, 17:04

    Still an issue.
  10. core-ci voted on patch set 3 V +1 11/04/21, 18:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18915

  11. Benni Mack commented on patch set 3 11/10/21, 11:53

    Hey Nikita, can we first update Bootstrap (can you take care of this) separately, and then come back to this change?
  12. Nikita Hovratov commented on patch set 3 11/10/21, 12:16

    Reply

    Oh, I thought we already updated. Ok let's do this first.
  13. Benni Mack uploaded patch set 4 11/15/21, 20:33

  14. core-ci voted on patch set 4 V +1 11/15/21, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19324

  15. Oli Bartsch commented on patch set 4 11/15/21, 21:03

    _main_form.scss:605

    Are we sure this won't lead to side effects? Looks really generic. I'm furthermore not able to reproduce the display issues, shown in forge. On which setup did you test this?
  16. Simon Schaufelberger commented on patch set 4 11/15/21, 21:17

    _main_form.scss:605 Reply

    @Oliver: this issue appears on Google Chrome on Ubuntu
  17. Oli Bartsch voted on patch set 4 V +1 CR +1 11/15/21, 21:54

  18. Stefan Bürk commented on patch set 4 11/16/21, 13:52

    _main_form.scss:605 Reply

    Cannot reproduce this with Linux Mint (based on Ubuntu), Google Chrome Version 96.0.4664.45 (Offizieller Build) (64-Bit) and current master.
  19. Benni Mack updated the commit message in patch set 5 11/18/21, 10:48

  20. Benni Mack voted on patch set 5 V +1 CR +1 11/18/21, 10:48

  21. core-ci voted on patch set 5 V +1 11/18/21, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19477

  22. Simon Schaufelberger commented on patch set 5 V +1 CR +1 11/23/21, 00:21

    yes, this fixes the issue!
  23. Simon Schaufelberger commented on patch set 5 11/23/21, 00:30

    _main_form.scss:605 Reply Unresolved

    ok maybe another setting is that I have increased the font size in my system settings to 1.20 because I have a 4k monitor and the font is just too tiny.
  24. Oli Bartsch voted on patch set 5 V +2 CR +2 11/23/21, 09:02

  25. Oli Bartsch merged patch set 6 11/23/21, 09:02