Review main Merged

71461[BUGFIX] Properly handle array key access in ExtendedTemplateService

Oli Bartsch CR +2 V +2 Normal +240 −9 updated 10/08/21, 07:43

Commit message

This fixes the ExtendedTemplateService->ext_getSetup()
method, which now properly handles array key accesses.

A new early return now also checks for an empty
key and returns the whole setup in this case.
This is a special case, needed for e.g. the
object browser, to still show the full setup
when object lists exist.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Tymoteusz Motylewski +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Tymoteusz Motylewski +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2839

Show 1014 earlier messages
  1. Oli Bartsch uploaded patch set 1 10/06/21, 12:30

  2. core-ci voted on patch set 1 V +1 10/06/21, 12:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17663

  3. Oliver Hader uploaded patch set 2 10/06/21, 14:45

  4. Oliver Hader voted on patch set 2 V +1 CR +1 10/06/21, 14:45

  5. core-ci voted on patch set 2 V +1 10/06/21, 15:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17677

  6. Oli Bartsch commented on patch set 2 V -1 10/06/21, 17:57

    On it
  7. Oli Bartsch uploaded patch set 3 10/06/21, 18:38

  8. core-ci voted on patch set 3 V +1 10/06/21, 18:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17693

  9. Stefan Froemken commented on patch set 3 V +1 CR -1 10/06/21, 19:01

    Thank you for the patch. It works now. Great. But you should rename the Test file ;-)
  10. Stefan Froemken commented on patch set 3 CR 0 10/06/21, 19:05

    Ihhh...what's that? All files are ending with "Cest". I removed my -1 for code review.
  11. Nikita Hovratov commented on patch set 3 10/07/21, 07:33

    Reply

    A Cest ending indicates a codeception testfile.
  12. Nikita Hovratov uploaded patch set 4 10/07/21, 08:48

  13. core-ci voted on patch set 4 V -1 10/07/21, 08:51 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17720

  14. Nikita Hovratov uploaded patch set 5 10/07/21, 09:00

  1. core-ci voted on patch set 5 V +1 10/07/21, 09:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17722

  2. Oliver Klee voted on patch set 5 CR +1 10/07/21, 09:30

  3. Nikita Hovratov uploaded patch set 6 10/07/21, 11:29

  4. Oliver Klee voted on patch set 6 CR +1 10/07/21, 11:44

  5. core-ci voted on patch set 6 V +1 10/07/21, 11:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17732

  6. Tymoteusz Motylewski commented on patch set 6 10/07/21, 12:26

    I'll provide some unit test for it
  7. Oli Bartsch commented on patch set 6 CR -1 10/07/21, 13:36

    Reply

    Thanks a lot. Then I will block for now.
  8. Tymoteusz Motylewski uploaded patch set 7 10/07/21, 13:39

  9. Tymoteusz Motylewski uploaded patch set 8 10/07/21, 13:41

  10. Tymoteusz Motylewski commented on patch set 8 10/07/21, 13:44

    here you go. Please take a look @Oliver whether all important cases are covered with my test. If not feel free to add it. You have more context about how the method is used.
  11. core-ci voted on patch set 7 V -1 10/07/21, 13:45 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17743

  12. Tymoteusz Motylewski uploaded patch set 9 10/07/21, 13:54

  13. Tymoteusz Motylewski commented on patch set 9 V -1 10/07/21, 13:56

    Reply

    uploaded another patchset. The dataset 'not empty key - 4th, non existing level' is failing now, but is green with previous implementation. Please take a look if it's expected. (to temporarily ignore notices in old implementation I've added \error_reporting(0); at the begining of the test localy)
    -1 until the failing test is fixed
  14. core-ci voted on patch set 8 V +1 10/07/21, 14:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17745

  15. core-ci voted on patch set 9 V -1 10/07/21, 14:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17749

  16. Oli Bartsch uploaded patch set 10 10/07/21, 16:17

  17. core-ci voted on patch set 10 V -1 10/07/21, 16:21 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17764

  18. Oli Bartsch uploaded patch set 11 10/07/21, 17:12

  19. Oli Bartsch commented on patch set 11 10/07/21, 17:16

    Reply

    I have added an early return for the case that an empty key is given. This is as mentioned in the commit message necessary to get the full setup dynamically. So no extra outside checks have to be performed. Another thing in the object browser is the divider of the object list. It's value is "-". This will now lead to an empty list. However this should be fixed by e.g. disabling this option. The method should not handle this special case.
  20. Oliver Klee wrote 10/07/21, 17:16

    Removed reviewer Oliver Klee.
  21. core-ci voted on patch set 11 V +1 10/07/21, 17:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17770

  22. Tymoteusz Motylewski voted on patch set 11 V +1 CR +1 10/07/21, 17:29

  23. Jochen Roth voted on patch set 11 V +1 CR +1 10/07/21, 21:47

  24. Benni Mack voted on patch set 11 V +2 CR +2 10/08/21, 07:43

  25. Benni Mack merged patch set 12 10/08/21, 07:43