Review main Merged

71464[BUGFIX] Fix TypoScript object browser search

Oli Bartsch CR +2 V +2 Easy +29 −17 updated 10/07/21, 11:16

Commit message

This fixes a couple of array key related PHP warnings,
triggered in the TypoScript object browser while searching.

This also fixes an error, leading to an empty search
result under some circumstances. A new acceptance
test is taking care, the search will always work
in the future.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1217

  1. Oli Bartsch uploaded patch set 1 10/06/21, 14:38

  2. Oli Bartsch updated the commit message in patch set 2 10/06/21, 14:40

  3. core-ci voted on patch set 1 V +1 10/06/21, 14:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17674

  4. core-ci voted on patch set 2 V +1 10/06/21, 15:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17675

  5. Oliver Hader voted on patch set 2 V +1 CR +1 10/06/21, 15:08

  6. Oli Bartsch uploaded patch set 3 10/06/21, 15:20

  7. Oliver Hader voted on patch set 3 V +1 CR +1 10/06/21, 15:25

  8. core-ci voted on patch set 3 V -1 10/06/21, 15:39 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17680

  9. Nikita Hovratov uploaded patch set 4 10/06/21, 16:20

  10. core-ci voted on patch set 4 V +1 10/06/21, 16:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17685

  11. Nikita Hovratov voted on patch set 4 V +1 CR +1 10/07/21, 07:28

  12. Nikita Hovratov uploaded patch set 5 10/07/21, 08:58

  13. core-ci voted on patch set 5 V +1 10/07/21, 09:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17721

  14. Benni Mack voted on patch set 5 CR +1 10/07/21, 10:29

  15. Nikita Hovratov voted on patch set 5 V +1 CR +1 10/07/21, 10:52

  16. Christian Kuhn voted on patch set 5 V +2 CR +2 10/07/21, 11:16

  17. Christian Kuhn merged patch set 6 10/07/21, 11:16