Review 10.4 Merged

71465[BUGFIX] Fix the generics annotations for ObjectManager(Interface)

Oliver Klee CR +2 V +2 Normal +36 −26 updated 10/09/21, 11:05

Commit message

To avoid PHPStan warnings in projects that use ObjectManagerInterface
as a type annotation, the ObjectManager(Interface) generics need to
be on the generating methods, not on the class/interface itself.

Also streamline the PHPDoc to be more consistent, and fix the semantics
(there are no object instances, only class instances) to avoid
confusing the reader.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Elias Häußler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Elias Häußler +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Oliver Klee uploaded patch set 1 10/06/21, 14:41

  2. core-ci voted on patch set 1 V +1 10/06/21, 14:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17676

  3. Elias Häußler voted on patch set 1 V +1 CR +1 10/08/21, 09:25

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 10/09/21, 11:05

  5. Andreas Kienast merged patch set 2 10/09/21, 11:05