Review main Merged

71466[BUGFIX] Address undefined array index warnings in PHP8

Oliver Hader CR +2 V +2 Easy +3 −3 updated 10/06/21, 16:15

Commit message

* for (missing) plugin namespace in `PluginEnhancer`
* for (optional) `X-Forwarded-*` HTTP headers in `GeneralUtility`

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Oliver Hader uploaded patch set 1 10/06/21, 15:13

  2. Oli Bartsch voted on patch set 1 V +1 CR +1 10/06/21, 15:20

  3. core-ci voted on patch set 1 V +1 10/06/21, 15:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17679

  4. Oliver Klee voted on patch set 1 CR +1 10/06/21, 16:12

  5. Oliver Klee commented on patch set 1 10/06/21, 16:12

    So far, this is an Oliver-only change. :-D
  6. Christian Kuhn voted on patch set 1 V +2 CR +2 10/06/21, 16:15

  7. Christian Kuhn commented on patch set 1 10/06/21, 16:15

    not anymore ;)
  8. Christian Kuhn merged patch set 2 10/06/21, 16:15