Review main Merged

71469[TASK] Raise doctrine/dbal:^2.13.4

Stefan Bürk CR +2 V +2 Easy +16 −15 updated 10/07/21, 10:39

Commit message

Brings fix for changed sqlite driver behaviour for php8.1,
which would fix a schemamigrator issue for php8.1.

 composer req doctrine/dbal:^2.13.4
 composer req doctrine/dbal:^2.13.4 -d typo3/sysext/core --no-update
 composer req doctrine/dbal:^2.13.4 -d typo3/sysext/install --no-update
 composer req doctrine/dbal:^2.13.4 -d typo3/sysext/redirects --no-update

Related test

 Build/Scripts/runTests.sh -s functional -p 8.1 -d sqlite -x \
   -e '--filter="SchemaMigratorTest::changeExistingIndex"'

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • crell +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1524

  1. Stefan Bürk uploaded patch set 1 10/06/21, 17:14

  2. core-ci voted on patch set 1 V -1 10/06/21, 17:18 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17688

  3. Stefan Bürk uploaded patch set 2 10/06/21, 23:30

  4. Stefan Bürk commented on patch set 3 10/06/21, 23:32

    Published edit on patch set 2.
  5. core-ci voted on patch set 3 V -1 10/06/21, 23:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17708

  6. core-ci voted on patch set 2 V +1 10/06/21, 23:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17707

  7. Stefan Bürk uploaded patch set 4 10/07/21, 00:11

  8. Stefan Bürk marked it ready for review 10/07/21, 00:12

  9. Stefan Bürk updated the commit message in patch set 5 10/07/21, 00:16

  10. core-ci voted on patch set 4 V -1 10/07/21, 00:21 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17710

  11. core-ci voted on patch set 4 V -1 10/07/21, 00:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17709

  12. core-ci voted on patch set 5 V -1 10/07/21, 00:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17711

  13. Stefan Bürk uploaded patch set 6 10/07/21, 00:38

  14. Stefan Bürk uploaded patch set 7 10/07/21, 00:50

  15. core-ci voted on patch set 6 V -1 10/07/21, 00:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17712

  16. core-ci voted on patch set 7 V +1 10/07/21, 01:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17713

  17. Stefan Bürk commented on patch set 7 10/07/21, 01:12

  18. core-ci commented on patch set 7 10/07/21, 02:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17715

  19. crell commented on patch set 7 CR +1 10/07/21, 07:45

    Does this allow us to remove the version-specific hack we added back in https://review.typo3.org/c/Packages/TYPO3.CMS/+/71238 ? (Maybe the whole test.)
  20. Stefan Bürk commented on patch set 7 10/07/21, 08:35

    Reply

    Nope. The pointent method is a sanatizing method, which has been implemented to get the expected output for sqlite prior to php8.1 matching with one matching dataset, as sqlite do return real integers instead of strings with php8.1. It's a similar issue, we need that method as long as expected data should match for <8.1 and 8.1. The test itself - why should it be removed ? If core is on min 8.1 the sanatizing method can be removed.
  21. Oliver Klee voted on patch set 7 CR +1 10/07/21, 09:30

  22. Christian Kuhn voted on patch set 7 V +1 CR +1 10/07/21, 10:38

  23. Benni Mack voted on patch set 7 V +2 CR +2 10/07/21, 10:39

  24. Benni Mack merged patch set 8 10/07/21, 10:39