Review main Merged

71471[BUGFIX] Incomplete setUp() in ClipboardTest

Christian Kuhn CR +2 V +2 Easy +1 −2 updated 10/06/21, 19:58

Commit message

$GLOBALS['LANG'] needs to be initialized in all
tests, not only for the first one of the test case.
This fixes a currently suppressed PHP 8.0 warning for
functional tests.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 10/06/21, 18:58

  2. Christian Kuhn updated the commit message in patch set 2 10/06/21, 19:06

  3. core-ci voted on patch set 1 V +1 10/06/21, 19:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17695

  4. core-ci voted on patch set 2 V +1 10/06/21, 19:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17697

  5. Stefan Bürk voted on patch set 2 CR +1 10/06/21, 19:31

  6. Stefan Bürk voted on patch set 2 V +1 10/06/21, 19:33

  7. Oli Bartsch voted on patch set 2 V +2 CR +2 10/06/21, 19:58

  8. Oli Bartsch merged patch set 3 10/06/21, 19:58