Review main Merged

71472[BUGFIX] Incomplete setup in TcaCategoryTest

Christian Kuhn CR +2 V +2 Easy +6 −0 updated 10/06/21, 19:57

Commit message

Some tests trigger access to $result['rootline'] and
$result['site']. In normal usages, those are set up by
the FormEngine $result defaults, which is not applied
if calling a data provider directly as done with the
functional test in question. Solution in to set the
values to defaults within tests.
This fixes a currently suppressed PHP 8.0 warning for
functional tests.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 10/06/21, 19:05

  2. core-ci voted on patch set 1 V +1 10/06/21, 19:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17696

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 10/06/21, 19:30

  4. Oli Bartsch voted on patch set 1 V +2 CR +2 10/06/21, 19:57

  5. Oli Bartsch merged patch set 2 10/06/21, 19:57