Review main Merged

71474[TASK] Adjust test expectations for php8.1 changed defaults

Stefan Bürk CR +2 V +2 Normal +48 −9 updated 10/06/21, 21:09

Commit message

PHP 8.1 has changed default flags for several methods like
'htmlspecialchars()' for example. That makes sense from a
technically perspective and should be adopted.

As these are browser output related we adopt the changed
defaults through not setting them now, where they were not
set.

This patch changes the expected value of some tests to match
against expected value reflecting the corresponding defaults
for used php version.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 68

  1. Stefan Bürk uploaded patch set 1 10/06/21, 19:28

  2. core-ci voted on patch set 1 V +1 10/06/21, 19:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17699

  3. Stefan Bürk uploaded patch set 2 10/06/21, 20:31

  4. core-ci voted on patch set 2 V +1 10/06/21, 20:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17700

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 10/06/21, 21:00

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 10/06/21, 21:03

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 10/06/21, 21:09

  8. Christian Kuhn merged patch set 3 10/06/21, 21:09