Review main Merged

71478[BUGFIX] Fix workspace state handling

Oli Bartsch CR +2 V +2 Normal +122 −74 updated 10/12/21, 08:54

Commit message

The WorkspaceMenu JavaScript module is used to
update the topbar elements, related to workspaces.

The required state handling is now simplified and
does no longer rely or manipulate "global" configuration
(top.TYPO3.configuration or top.TYPO3.Backend).
This therefore also allows to remove the "inWorkspace"
value, set in the BackendController.

Additionally, the "check icon", in front of the
current selected workspace menu item, is now
properly updated again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1217

  1. Oli Bartsch uploaded patch set 1 10/06/21, 22:45

  2. core-ci voted on patch set 1 V -1 10/06/21, 23:03 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17706

  3. Oli Bartsch rebased onto patch set 2 10/11/21, 11:49

  4. core-ci voted on patch set 2 V -1 10/11/21, 12:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17914

  5. Oli Bartsch uploaded patch set 3 10/11/21, 14:08

  6. core-ci voted on patch set 3 V +1 10/11/21, 14:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17922

  7. Benni Mack commented on patch set 3 10/11/21, 14:42

    BackendController.php:359

    I suggest to return "pageModule" and "pageModuleUrl" in the AJAX endpoint "ajax_workspace_switch" so we can remove the other options as well.
  8. Christian Kuhn commented on patch set 3 V +1 CR +1 10/11/21, 15:09

    BackendController.php:359 Reply

    separate patch?
  9. Oli Bartsch uploaded patch set 4 10/11/21, 15:39

  10. Oli Bartsch commented on patch set 4 10/11/21, 15:41

    BackendController.php:359 Reply

    Sorry, was already on it.
  11. core-ci voted on patch set 4 V +1 10/11/21, 15:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17925

  12. Oli Bartsch uploaded patch set 5 10/11/21, 16:46

  13. core-ci voted on patch set 5 V +1 10/11/21, 17:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17928

  14. Benni Mack voted on patch set 5 V +1 CR +1 10/12/21, 08:17

  15. Jochen Roth voted on patch set 5 V +1 CR +1 10/12/21, 08:35

  16. Benni Mack voted on patch set 5 V +2 CR +2 10/12/21, 08:54

  17. Benni Mack merged patch set 6 10/12/21, 08:54