Review main Merged

71483[BUGFIX] Set fe_user email field to eval "email"

Jochen Roth CR +2 V +2 Easy +2 −2 updated 10/07/21, 21:17

Commit message

Currently the fe_user field email has a eval value
of "trim". So it does not verify the given email.

This has been fixed by setting eval to "email" and
trim the email before validation. On top of that
the validation flash message now shows the correct
value that was entered.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1520

  1. Jochen Roth uploaded patch set 1 10/07/21, 13:15

  2. core-ci voted on patch set 1 V +1 10/07/21, 13:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17740

  3. Christian Kuhn commented on patch set 1 CR -1 10/07/21, 14:18

    DataHandler.php:2719

    I'm unsure if we should do this: *if* there are whitespaces or tabs entered, the value should be actively updated to remove them. that is what 'eval=trim' does currently. Doing that implicit here, will keep whitespaces and tabs in the data value if the rest is a valid mail. This may lead unexpected situations where consuming code will have to do an explicit trim() again. I'd propose to set eval='trim,email' instead and drop this trim() here, again.
  4. Jochen Roth uploaded patch set 2 10/07/21, 14:36

  5. Jochen Roth uploaded patch set 3 10/07/21, 14:38

  6. core-ci voted on patch set 2 V +1 10/07/21, 14:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17752

  7. core-ci voted on patch set 3 V +1 10/07/21, 14:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17753

  8. Jochen Roth uploaded patch set 4 10/07/21, 15:00

  9. core-ci voted on patch set 4 V +1 10/07/21, 15:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17756

  10. Jochen Roth uploaded patch set 5 10/07/21, 15:39

  11. core-ci voted on patch set 5 V +1 10/07/21, 15:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17760

  12. Christian Kuhn voted on patch set 5 V +1 CR +1 10/07/21, 16:01

  13. Georg Ringer commented on patch set 5 CR -1 10/07/21, 17:22

    This is a potential breaking change
  14. Christian Kuhn commented on patch set 5 10/07/21, 17:26

    Reply Unresolved

    Could you elaborate on this, Georg? I don't easily see how an added validation of the email field of fe_users can be breaking. It basically means an editor can't update the record if it edits an existing record with an invalid email or tries to add a fe_user record with an invalid email. What's your use case for a breaking change consideration here?
  15. Christian Kuhn commented on patch set 5 10/07/21, 17:31

    Note: This does not make the email field required: You can still add an fe_user without email. but if you add an email, it has to be a valid email.
  16. Christian Kuhn commented on patch set 5 10/07/21, 17:31

    DataHandler.php:2719 Reply

    Done
  17. Wouter Wolters voted on patch set 5 V +1 CR +1 10/07/21, 17:50

  18. Georg Ringer commented on patch set 5 V +1 CR +1 10/07/21, 21:17

    sry thought the value would be removed if invalid
  19. Georg Ringer voted on patch set 5 V +2 CR +2 10/07/21, 21:17

  20. Georg Ringer merged patch set 6 10/07/21, 21:17