71483[BUGFIX] Set fe_user email field to eval "email"
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Wouter Wolters +1
- Christian Kuhn +1
-
Verified V +2 Done
- Georg Ringer +2
- Wouter Wolters +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1520
-
Jochen Roth uploaded patch set 1 10/07/21, 13:15
-
core-ci voted on patch set 1 V +1 10/07/21, 13:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17740
-
Christian Kuhn commented on patch set 1 CR -1 10/07/21, 14:18
-
Jochen Roth uploaded patch set 2 10/07/21, 14:36
-
Jochen Roth uploaded patch set 3 10/07/21, 14:38
-
core-ci voted on patch set 2 V +1 10/07/21, 14:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17752
-
core-ci voted on patch set 3 V +1 10/07/21, 14:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17753
-
Jochen Roth uploaded patch set 4 10/07/21, 15:00
-
core-ci voted on patch set 4 V +1 10/07/21, 15:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17756
-
Jochen Roth uploaded patch set 5 10/07/21, 15:39
-
core-ci voted on patch set 5 V +1 10/07/21, 15:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17760
-
Christian Kuhn voted on patch set 5 V +1 CR +1 10/07/21, 16:01
-
Georg Ringer commented on patch set 5 CR -1 10/07/21, 17:22
This is a potential breaking change -
Christian Kuhn commented on patch set 5 10/07/21, 17:26
Reply Unresolved
Could you elaborate on this, Georg? I don't easily see how an added validation of the email field of fe_users can be breaking. It basically means an editor can't update the record if it edits an existing record with an invalid email or tries to add a fe_user record with an invalid email. What's your use case for a breaking change consideration here? -
Christian Kuhn commented on patch set 5 10/07/21, 17:31
Note: This does not make the email field required: You can still add an fe_user without email. but if you add an email, it has to be a valid email. -
Christian Kuhn commented on patch set 5 10/07/21, 17:31
DataHandler.php:2719ReplyDone -
Wouter Wolters voted on patch set 5 V +1 CR +1 10/07/21, 17:50
-
Georg Ringer commented on patch set 5 V +1 CR +1 10/07/21, 21:17
sry thought the value would be removed if invalid -
Georg Ringer voted on patch set 5 V +2 CR +2 10/07/21, 21:17
-
Georg Ringer merged patch set 6 10/07/21, 21:17
DataHandler.php:2719