Review main Merged

71484[BUGFIX] Restore inconsistent language highlighting

Oli Bartsch CR +2 V +2 Easy +12 −0 updated 10/08/21, 07:45

Commit message

The page module displays a flash message for page
translations with inconsistent ("mixed mode") content
elements. The last sentence of the flash message reads:
"We highlighted the problematic records for you". This
however was no longer the case in the fluid based page
module.

Therefore, this patch restores highlighting of such records.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Jochen Roth +1
    • Wouter Wolters +1
    • Rachel Foucard +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Jochen Roth +1
    • Rachel Foucard +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. Oli Bartsch uploaded patch set 1 10/07/21, 13:37

  2. Oli Bartsch commented on patch set 1 V -1 10/07/21, 13:51

    Need to handle free mode correctly
  3. core-ci voted on patch set 1 V +1 10/07/21, 13:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17742

  4. Oli Bartsch uploaded patch set 2 10/07/21, 15:12

  5. core-ci voted on patch set 2 V +1 10/07/21, 15:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17757

  6. Rachel Foucard commented on patch set 2 10/07/21, 16:52

    GridColumnItem.php:112

    Hi Oliver, would it be possible to use a warning class instead of danger? thank you in advance, Rachel
  7. Jochen Roth voted on patch set 2 V +1 CR +1 10/07/21, 16:53

  8. Oli Bartsch uploaded patch set 3 10/07/21, 19:50

  9. Oli Bartsch commented on patch set 3 10/07/21, 19:50

    GridColumnItem.php:112 Reply

    Done
  10. Jochen Roth voted on patch set 3 V +1 CR +1 10/07/21, 19:53

  11. Rachel Foucard voted on patch set 3 V +1 CR +1 10/07/21, 19:56

  12. core-ci voted on patch set 3 V +1 10/07/21, 20:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17779

  13. Wouter Wolters voted on patch set 3 CR +1 10/07/21, 21:28

  14. Georg Ringer voted on patch set 3 V +2 CR +2 10/08/21, 07:45

  15. Georg Ringer merged patch set 4 10/08/21, 07:45