Review main Merged

71485[BUGFIX] errorHandling setup in site based functional tests

Christian Kuhn CR +2 V +2 Easy +11 −33 updated 10/07/21, 15:05

Commit message

Some functional tests using SiteBasedTestTrait create
a broken site config, example:

base: 'https://website.local/'
errorHandling:
  -
    -
      errorFluidTemplate: typo3/[...]/FluidError.html
      errorFluidTemplatesRootPath: ''
      errorFluidLayoutsRootPath: ''
      errorFluidPartialsRootPath: ''
      errorHandler: Fluid
      errorCode: 404

It should be:

base: 'https://website.local/'
errorHandling:
  -
    errorFluidTemplate: typo3/[...]/FluidError.html
    errorFluidTemplatesRootPath: ''
    errorFluidLayoutsRootPath: ''
    errorFluidPartialsRootPath: ''
    errorHandler: Fluid
    errorCode: 404

This is due to a superfluous array when creating the
site config. The patch adapts usages.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/07/21, 13:40

  2. core-ci voted on patch set 1 V +1 10/07/21, 13:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17744

  3. Jochen Roth voted on patch set 1 V +1 CR +1 10/07/21, 14:15

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 10/07/21, 14:46

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/07/21, 15:05

  6. Christian Kuhn merged patch set 2 10/07/21, 15:05