Review main Merged

71487[TASK] Rename method inside PageLayoutController

Benni Mack CR +2 V +2 Easy +4 −4 updated 10/07/21, 17:46

Commit message

Give the actual method the name "generateMessagesForCurrentPage"
as no flash messages are generated.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Sybille Peters +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Benni Mack uploaded patch set 1 10/07/21, 14:42

  2. core-ci voted on patch set 1 V -1 10/07/21, 14:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17754

  3. core-ci voted on patch set 1 V +1 10/07/21, 15:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17754

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 10/07/21, 15:18

  5. Christian Kuhn commented on patch set 1 10/07/21, 15:21

    PageLayoutController.php:364

    "the for" -> "for the"
  6. Sybille Peters commented on patch set 1 10/07/21, 15:21

    Minor nitpick, otherwise looks ok to me.

    PageLayoutController.php:364

    "Generate various messages (....) the for" should be "for the" ?
  7. Christian Kuhn uploaded patch set 2 10/07/21, 15:22

  8. Christian Kuhn commented on patch set 2 V +1 CR +1 10/07/21, 15:23

    PageLayoutController.php:364 Reply

    Done

    PageLayoutController.php:364 Reply

    Done
  9. Sybille Peters voted on patch set 2 CR +1 10/07/21, 15:23

  10. core-ci voted on patch set 2 V +1 10/07/21, 15:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17759

  11. Wouter Wolters voted on patch set 2 V +1 CR +1 10/07/21, 17:40

  12. Christian Kuhn voted on patch set 2 V +2 CR +2 10/07/21, 17:46

  13. Christian Kuhn merged patch set 3 10/07/21, 17:46