71487[TASK] Rename method inside PageLayoutController
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Wouter Wolters +1
- Sybille Peters +1
-
Verified V +2 Done
- Christian Kuhn +2
- Wouter Wolters +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1013
-
Benni Mack uploaded patch set 1 10/07/21, 14:42
-
core-ci voted on patch set 1 V -1 10/07/21, 14:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17754
-
core-ci voted on patch set 1 V +1 10/07/21, 15:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17754
-
Oli Bartsch voted on patch set 1 V +1 CR +1 10/07/21, 15:18
-
Christian Kuhn commented on patch set 1 10/07/21, 15:21
-
Sybille Peters commented on patch set 1 10/07/21, 15:21
Minor nitpick, otherwise looks ok to me.PageLayoutController.php:364"Generate various messages (....) the for" should be "for the" ? -
Christian Kuhn uploaded patch set 2 10/07/21, 15:22
-
Christian Kuhn commented on patch set 2 V +1 CR +1 10/07/21, 15:23
PageLayoutController.php:364ReplyDonePageLayoutController.php:364ReplyDone -
Sybille Peters voted on patch set 2 CR +1 10/07/21, 15:23
-
core-ci voted on patch set 2 V +1 10/07/21, 15:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17759
-
Wouter Wolters voted on patch set 2 V +1 CR +1 10/07/21, 17:40
-
Christian Kuhn voted on patch set 2 V +2 CR +2 10/07/21, 17:46
-
Christian Kuhn merged patch set 3 10/07/21, 17:46
PageLayoutController.php:364