Review main Merged

71488[TASK] Ensure record_commit parameters are not reused

TYPO3com CR +2 V +2 Easy +24 −14 updated 10/08/21, 16:31

Commit message

When using the "saveAndClose" option for a newContentElementWizard
item, the target link forwards directly to the record_commit route
instead of FormEngine. Previously the parameters for this link
were added to an array, which was then never reset after used
for the link creation. This therefore resulted in multiple
elements were created as soon as the "saveAndClose" option
was set multiple times.

This is now fixed by not using a single use variable anymore,
but directly building the data array in the link, like it's
already done for the FormEngine links.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 47

  1. TYPO3com uploaded patch set 1 10/07/21, 15:16

  2. core-ci voted on patch set 1 V +1 10/07/21, 15:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17758

  3. Oli Bartsch uploaded patch set 2 10/07/21, 21:21

  4. Oli Bartsch voted on patch set 2 V +1 CR +1 10/07/21, 21:21

  5. core-ci voted on patch set 2 V +1 10/07/21, 21:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17784

  6. Benni Mack voted on patch set 2 V +2 CR +2 10/08/21, 16:30

  7. Benni Mack merged patch set 3 10/08/21, 16:31