Review main Merged

71489[BUGFIX] Incomplete setup in ScriptViewHelperTest

Christian Kuhn CR +2 V +2 Easy +1 −0 updated 10/07/21, 17:47

Commit message

Argument 'priority' is accessed in ScriptViewHelper
without fallback. This is fine, since fluid sets
arguments to default values in normal operation.

The test case however circumvents this argument
initialization, so a value has to be set in the test.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/07/21, 16:00

  2. core-ci voted on patch set 1 V +1 10/07/21, 16:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17762

  3. Simon Schaufelberger voted on patch set 1 V +1 CR +1 10/07/21, 17:12

  4. Wouter Wolters voted on patch set 1 V +1 CR +1 10/07/21, 17:38

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/07/21, 17:46

  6. Christian Kuhn merged patch set 2 10/07/21, 17:47