71490[BUGFIX] Fix validation in form override settings
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1930
Show 35 earlier messages
-
Nikita Hovratov uploaded patch set 1 10/07/21, 16:16
-
core-ci voted on patch set 1 V -1 10/07/21, 16:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17763
-
Nikita Hovratov uploaded patch set 2 10/07/21, 16:26
-
core-ci voted on patch set 2 V -1 10/07/21, 16:30 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17765
-
Nikita Hovratov uploaded patch set 3 10/07/21, 16:40
-
core-ci voted on patch set 3 V -1 10/07/21, 16:45 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17766
-
Nikita Hovratov uploaded patch set 4 10/07/21, 16:48
-
core-ci voted on patch set 4 V +1 10/07/21, 17:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17768
-
Wouter Wolters voted on patch set 4 CR +1 10/07/21, 17:52
-
Christian Kuhn commented on patch set 4 10/07/21, 18:32
weird. i roughly remember that I adapted something in this area years ago: afaik, flexFormTools resolution takes care there is *always* a sheet when a DS is parsed ... i stumbled upon that with my refactoring in https://review.typo3.org/c/Packages/TYPO3.CMS/+/71097 recently. I don't say you're not right here, but I think this detail needs a good review. -
Benni Mack updated the commit message in patch set 5 11/18/21, 10:40
-
core-ci voted on patch set 5 V +1 11/18/21, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19453
-
Benni Mack wrote 11/29/21, 10:19
Change destination moved from master to main -
Nikita Hovratov updated the commit message in patch set 6 11/29/21, 11:45
-
core-ci voted on patch set 6 V +1 11/29/21, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19974
-
Nikita Hovratov uploaded patch set 7 12/01/21, 20:35
-
Nikita Hovratov commented on patch set 7 12/01/21, 20:42
Reply
I'm refering to this line: https://github.com/TYPO3/typo3/blob/bbb675a5f223bc0f57899240e13274ede12fcb89/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L2949 It handles both cases, with and without TCEforms around a field definition. The mistake of the form extension is to add it to the "sections" part, too. Here: https://github.com/TYPO3/typo3/blob/bbb675a5f223bc0f57899240e13274ede12fcb89/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L2917 it does not check for "TCEforms" and thus everything inside is not evaluated. IMO this patch resolves the correct usage. It does not intervene in flexform internals. -
core-ci voted on patch set 7 V +1 12/01/21, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20364
-
Nikita Hovratov uploaded patch set 8 12/01/21, 20:58
-
core-ci voted on patch set 8 V +1 12/01/21, 21:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20368
-
Nikita Hovratov uploaded patch set 9 12/16/21, 16:32
-
Nikita Hovratov commented on patch set 9 12/16/21, 16:34
Reply
Done -
core-ci voted on patch set 9 V +1 12/16/21, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21192
-
Nikita Hovratov uploaded patch set 10 12/16/21, 18:26
-
core-ci voted on patch set 10 V +1 12/16/21, 18:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21195
-
Nikita Hovratov uploaded patch set 11 12/16/21, 19:25
-
core-ci voted on patch set 11 V +1 12/16/21, 19:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21196
-
Christian Kuhn voted on patch set 11 V +1 CR +1 12/16/21, 21:26
-
Benni Mack voted on patch set 11 V +2 CR +2 12/16/21, 22:46
-
Benni Mack merged patch set 12 12/16/21, 22:46