Review main Merged

71491[BUGFIX] Extbase UriBuilder warning in Backend context

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 10/07/21, 19:39

Commit message

The extbase UriBuilder can be used in backend context,
ActionMenuItemViewHelper does that for instance. The
code accesses $GLOBALS['TSFE'] at one point, which
may not be set.

The ActionMenuItemViewHelperTest triggers this, but
it should be a general asset of UriBuilder to work
without TSFE, so this is not considered an incomplete
test setup, but fixed in UriBuilder directly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/07/21, 16:41

  2. core-ci voted on patch set 1 V +1 10/07/21, 17:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17767

  3. Wouter Wolters voted on patch set 1 V +1 CR +1 10/07/21, 17:38

  4. Nikita Hovratov voted on patch set 1 V +1 CR +1 10/07/21, 19:38

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/07/21, 19:39

  6. Christian Kuhn merged patch set 2 10/07/21, 19:39