Review main Merged

71493[BUGFIX] Incomplete setup in ImageViewHelperTest

Christian Kuhn CR +2 V +2 Easy +5 −4 updated 10/07/21, 19:27

Commit message

* Arguments with default values are registered with their
  default values in fluid by default. Tests that circumvent
  argument initialization by setting them directly must set
  them. The patch adds this for the "exception" tests in
  ImageViewHelperTest.

* The main tests of ImageViewHelperTest run in backend scope.
  The FAL logic triggers StoragePermissionsAspect in this
  scope, which needs a $GLOBALS['BE_USER'], but that is not
  set up by the tests. The patch initializes a backend user.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/07/21, 17:13

  2. core-ci voted on patch set 1 V +1 10/07/21, 17:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17771

  3. Wouter Wolters voted on patch set 1 V +1 CR +1 10/07/21, 17:37

  4. Nikita Hovratov voted on patch set 1 V +1 CR +1 10/07/21, 19:26

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/07/21, 19:27

  6. Christian Kuhn merged patch set 2 10/07/21, 19:27