71494[BUGFIX] PHP 8.0 warning from ContentObjectRenderer
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Wouter Wolters +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Benni Mack +2
- Wouter Wolters +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1115
-
Christian Kuhn uploaded patch set 1 10/07/21, 17:45
-
Wouter Wolters voted on patch set 1 V +1 CR +1 10/07/21, 17:50
-
core-ci voted on patch set 1 V -1 10/07/21, 18:06 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17772
-
Christian Kuhn uploaded patch set 2 10/07/21, 18:21
-
core-ci voted on patch set 2 V +1 10/07/21, 18:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17775
-
Christian Kuhn uploaded patch set 3 10/07/21, 19:53
-
Christian Kuhn uploaded patch set 4 10/07/21, 19:58
-
Nikita Hovratov voted on patch set 4 V +1 CR +1 10/07/21, 20:03
-
core-ci voted on patch set 3 V +1 10/07/21, 20:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17780
-
core-ci voted on patch set 4 V +1 10/07/21, 20:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17781
-
Oli Bartsch commented on patch set 4 10/07/21, 20:33
-
Christian Kuhn commented on patch set 4 10/07/21, 20:40
ContentObjectRenderer.php:5161Replyyes, but less expressive, imho. the if makes it more clear. -
Wouter Wolters voted on patch set 4 V +1 CR +1 10/07/21, 21:23
-
Benni Mack voted on patch set 4 V +2 CR +2 10/08/21, 06:19
-
Benni Mack merged patch set 5 10/08/21, 06:19
ContentObjectRenderer.php:5161