Review main Merged

71494[BUGFIX] PHP 8.0 warning from ContentObjectRenderer

Christian Kuhn CR +2 V +2 Easy +6 −2 updated 10/08/21, 06:19

Commit message

TypoScript options config.spamProtectEmailAddresses_atSubst
and config.spamProtectEmailAddresses_lastDotSubst may not
be set. Use null coalescing operator to sanitize access.

Link/EmailViewHelperTest stumbles here and also needs a
proper initialization of $GLOBALS['BE_USER'].

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1115

  1. Christian Kuhn uploaded patch set 1 10/07/21, 17:45

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 10/07/21, 17:50

  3. core-ci voted on patch set 1 V -1 10/07/21, 18:06 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17772

  4. Christian Kuhn uploaded patch set 2 10/07/21, 18:21

  5. core-ci voted on patch set 2 V +1 10/07/21, 18:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17775

  6. Christian Kuhn uploaded patch set 3 10/07/21, 19:53

  7. Christian Kuhn uploaded patch set 4 10/07/21, 19:58

  8. Nikita Hovratov voted on patch set 4 V +1 CR +1 10/07/21, 20:03

  9. core-ci voted on patch set 3 V +1 10/07/21, 20:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17780

  10. core-ci voted on patch set 4 V +1 10/07/21, 20:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17781

  11. Oli Bartsch commented on patch set 4 10/07/21, 20:33

    ContentObjectRenderer.php:5161

    Why do we not just use: $atLabel = trim($tsfe->config['config']['spamProtectEmailAddresses_atSubst'] ?? '') ?: '(at)';
  12. Christian Kuhn commented on patch set 4 10/07/21, 20:40

    ContentObjectRenderer.php:5161 Reply

    yes, but less expressive, imho. the if makes it more clear.
  13. Wouter Wolters voted on patch set 4 V +1 CR +1 10/07/21, 21:23

  14. Benni Mack voted on patch set 4 V +2 CR +2 10/08/21, 06:19

  15. Benni Mack merged patch set 5 10/08/21, 06:19