Review main Merged

71495[BUGFIX] Incomplete setup in FileViewHelperTest

Christian Kuhn CR +2 V +2 Easy +1 −0 updated 10/07/21, 19:09

Commit message

The FileViewHelperTest runs in backend scope, a valid
backend user needs to be initialized to satisfy
StoragePermissionsAspect.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 10/07/21, 17:54

  2. core-ci voted on patch set 1 V +1 10/07/21, 18:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17773

  3. Wouter Wolters voted on patch set 1 V +1 CR +1 10/07/21, 18:30

  4. Georg Ringer voted on patch set 1 V +2 CR +2 10/07/21, 19:09

  5. Georg Ringer merged patch set 2 10/07/21, 19:09