Review main Merged

71502[BUGFIX] Clean up clipboard before using it in ContextMenu

Oli Bartsch CR +2 V +2 Easy +4 −0 updated 10/08/21, 13:11

Commit message

Some item providers (context menu) access
clipboard information. Since the clipboard was
previously not properly initialized, this led to
exceptions, since no longer existing elements
could falsely be retrieved.

This is now fixed by cleaning up the clipboard
before making it available for the context
menu item providers.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Oli Bartsch uploaded patch set 1 10/07/21, 23:00

  2. core-ci voted on patch set 1 V +1 10/07/21, 23:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17790

  3. Benni Mack voted on patch set 1 V +1 CR +1 10/08/21, 08:03

  4. Nikita Hovratov commented on patch set 1 10/08/21, 10:33

    I cannot reproduce this error on current master. Can you?
  5. Oli Bartsch commented on patch set 1 10/08/21, 10:50

    Reply

    Sure. Just create a new folder in filelist, copy it (so "normal" clipboard mode), remove it again and try to open the context menu on another folder.
  6. Nikita Hovratov commented on patch set 1 V +1 CR +1 10/08/21, 11:48

    Reply

    Thanks, I thought sys folder were the problem.
  7. Oli Bartsch voted on patch set 1 V +2 CR +2 10/08/21, 13:11

  8. Oli Bartsch merged patch set 2 10/08/21, 13:11