Review main Merged

71503[BUGFIX] Prevent undefined key warnings in suggest wizard

Robert Kärner CR +2 V +2 Easy +13 −13 updated 10/08/21, 15:43

Commit message

Several undefined array key warnings prevented the
TCA suggestion wizard from showing results.
These have been fixed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1519

  1. Robert Kärner uploaded patch set 1 10/08/21, 09:01

  2. Robert Kärner uploaded patch set 2 10/08/21, 09:05

  3. core-ci voted on patch set 1 V +1 10/08/21, 09:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17804

  4. Benni Mack voted on patch set 2 CR +1 10/08/21, 09:25

  5. core-ci voted on patch set 2 V +1 10/08/21, 09:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17805

  6. Oliver Klee voted on patch set 2 CR +1 10/08/21, 10:49

  7. Nikita Hovratov uploaded patch set 3 10/08/21, 10:55

  8. Nikita Hovratov commented on patch set 3 V +1 10/08/21, 10:56

    I've found another one.
  9. Nikita Hovratov commented on patch set 3 10/08/21, 10:58

    SuggestWizardController.php:235

    do we want to write it like: is_array($var[$key] ?? null) It's a bit shorter.
  10. Oli Bartsch commented on patch set 3 10/08/21, 10:58

    SuggestWizardController.php:235

    Could we please use is_array($wizardConfig[$queryTable] ?? null) and avoid the extra isset() Same for the other occurrences.
  11. Oli Bartsch commented on patch set 3 10/08/21, 10:59

    SuggestWizardController.php:235 Reply

    Sorry, Nikita already proposed this.
  12. Robert Kärner commented on patch set 3 10/08/21, 11:05

    SuggestWizardController.php:235 Reply

    Sounds good, I agree. Either you can upload a new patchset, or I will do in an hour after having lunch.
  13. core-ci voted on patch set 3 V +1 10/08/21, 11:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17811

  14. Robert Kärner uploaded patch set 4 10/08/21, 12:05

  15. Robert Kärner commented on patch set 4 10/08/21, 12:05

    SuggestWizardController.php:235 Reply

    Done
  16. core-ci voted on patch set 4 V +1 10/08/21, 12:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17814

  17. Nikita Hovratov voted on patch set 4 V +1 CR +1 10/08/21, 14:59

  18. Oli Bartsch voted on patch set 4 V +2 CR +2 10/08/21, 15:43

  19. Oli Bartsch merged patch set 5 10/08/21, 15:43