71503[BUGFIX] Prevent undefined key warnings in suggest wizard
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Oli Bartsch +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1519
-
Robert Kärner uploaded patch set 1 10/08/21, 09:01
-
Robert Kärner uploaded patch set 2 10/08/21, 09:05
-
core-ci voted on patch set 1 V +1 10/08/21, 09:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17804
-
Benni Mack voted on patch set 2 CR +1 10/08/21, 09:25
-
core-ci voted on patch set 2 V +1 10/08/21, 09:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17805
-
Oliver Klee voted on patch set 2 CR +1 10/08/21, 10:49
-
Nikita Hovratov uploaded patch set 3 10/08/21, 10:55
-
Nikita Hovratov commented on patch set 3 V +1 10/08/21, 10:56
I've found another one. -
Nikita Hovratov commented on patch set 3 10/08/21, 10:58
SuggestWizardController.php:235do we want to write it like: is_array($var[$key] ?? null) It's a bit shorter. -
Oli Bartsch commented on patch set 3 10/08/21, 10:58
SuggestWizardController.php:235Could we please use is_array($wizardConfig[$queryTable] ?? null) and avoid the extra isset() Same for the other occurrences. -
Oli Bartsch commented on patch set 3 10/08/21, 10:59
SuggestWizardController.php:235ReplySorry, Nikita already proposed this. -
Robert Kärner commented on patch set 3 10/08/21, 11:05
SuggestWizardController.php:235ReplySounds good, I agree. Either you can upload a new patchset, or I will do in an hour after having lunch. -
core-ci voted on patch set 3 V +1 10/08/21, 11:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17811
-
Robert Kärner uploaded patch set 4 10/08/21, 12:05
-
Robert Kärner commented on patch set 4 10/08/21, 12:05
SuggestWizardController.php:235ReplyDone -
core-ci voted on patch set 4 V +1 10/08/21, 12:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17814
-
Nikita Hovratov voted on patch set 4 V +1 CR +1 10/08/21, 14:59
-
Oli Bartsch voted on patch set 4 V +2 CR +2 10/08/21, 15:43
-
Oli Bartsch merged patch set 5 10/08/21, 15:43