Review main Merged

71504[BUGFIX] Enforce setCopyMode in clipboard

Jochen Roth CR +2 V +2 Easy +10 −12 updated 10/19/21, 13:24

Commit message

The clipboard component features helper methods,
which generate a URL to update the clipboard
state with new elements. Those are used in
recordlist and filelist.

Previously the "setCopyMode" parameter was
only set in case the element should be "copied".
This then might lead to no "mode" set in the
clipboardData at all. Like other modules
already do, the helper methods do now always
set the "setCopyMode" parameter to enforce
the generation of the "mode" key in the
clipboardData.

Anyways, an access of the "mode" in the page
module is secured by a null collapse operator.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • Nikita Hovratov +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1215

  1. Jochen Roth uploaded patch set 1 10/08/21, 09:05

  2. Xavier Perseguers voted on patch set 1 V +1 CR +1 10/08/21, 09:10

  3. core-ci voted on patch set 1 V +1 10/08/21, 09:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17806

  4. Oli Bartsch commented on patch set 1 CR -1 10/08/21, 10:29

    Let me check this. IMO this should be set.
  5. Oli Bartsch uploaded patch set 2 10/08/21, 10:45

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 10/08/21, 10:45

  7. core-ci voted on patch set 2 V -1 10/08/21, 10:48 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17810

  8. Oli Bartsch uploaded patch set 3 10/08/21, 10:55

  9. core-ci voted on patch set 3 V +1 10/08/21, 11:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17812

  10. Jochen Roth voted on patch set 3 V +1 CR +1 10/08/21, 11:38

  11. Nikita Hovratov voted on patch set 3 V +1 CR +1 10/08/21, 12:11

  12. Oli Bartsch voted on patch set 3 V +1 CR +1 10/08/21, 13:12

  13. Oliver Hader voted on patch set 3 CR +1 10/08/21, 17:09

  14. Christian Kuhn voted on patch set 3 V +2 CR +2 10/19/21, 13:24

  15. Christian Kuhn merged patch set 4 10/19/21, 13:24