71508[BUGFIX] Do not prefix source set path with absRefPrefix
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Helmut Hummel +1
-
Verified V +2 Done
- Benni Mack +2
- Helmut Hummel +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1218
-
Jochen Roth uploaded patch set 1 10/08/21, 12:58
-
Jochen Roth updated the commit message in patch set 2 10/08/21, 13:01
-
Benni Mack commented on patch set 2 10/08/21, 13:06
-
core-ci voted on patch set 1 V +1 10/08/21, 13:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17816
-
core-ci voted on patch set 2 V +1 10/08/21, 13:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17817
-
Jochen Roth uploaded patch set 3 10/08/21, 13:31
-
Jochen Roth updated the commit message in patch set 4 10/08/21, 13:32
-
core-ci voted on patch set 3 V +1 10/08/21, 13:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17819
-
core-ci voted on patch set 4 V +1 10/08/21, 13:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17820
-
Helmut Hummel commented on patch set 4 V -1 10/08/21, 14:30
ImageContentObject.php:234ReplyThe thing is, that $this->cObj->getImgResource() can still return sourceInfo from Gifbuilder, which isn't FAL, which means absRefPrefix needs to be applied there as well, similar to the code from a single image here: https://github.com/TYPO3/typo3/blob/46e8a7025a0e3d770949f02c45402179ad3beb54/typo3/sysext/frontend/Classes/ContentObject/ImageContentObject.php#L64-L66 I only overlooked the responsive rendering part in the previous patch -
Jochen Roth uploaded patch set 5 10/08/21, 15:08
-
Jochen Roth uploaded patch set 6 10/08/21, 15:08
-
core-ci voted on patch set 5 V +1 10/08/21, 15:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17828
-
core-ci voted on patch set 6 V +1 10/08/21, 15:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17829
-
Helmut Hummel voted on patch set 6 V +1 CR +1 10/08/21, 16:19
-
Benni Mack voted on patch set 6 V +2 CR +2 10/08/21, 16:27
-
Benni Mack merged patch set 7 10/08/21, 16:27
-
Benni Mack commented on patch set 7 10/08/21, 16:27
ImageContentObject.php:234ReplyAck
ImageContentObject.php:234