Review main Merged

71508[BUGFIX] Do not prefix source set path with absRefPrefix

Jochen Roth CR +2 V +2 Easy +6 −1 updated 10/08/21, 16:27

Commit message

The paths for source set images is currently prefixed
with a slash which causes duplicated slashes at the
beginng of the path so images are not displayed anymore.

This has been fixed by removing the url prefix for
source sets.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Helmut Hummel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1218

  1. Jochen Roth uploaded patch set 1 10/08/21, 12:58

  2. Jochen Roth updated the commit message in patch set 2 10/08/21, 13:01

  3. Benni Mack commented on patch set 2 10/08/21, 13:06

    ImageContentObject.php:234

    I don't think we need the $urlPrefix here at all anymore.
  4. core-ci voted on patch set 1 V +1 10/08/21, 13:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17816

  5. core-ci voted on patch set 2 V +1 10/08/21, 13:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17817

  6. Jochen Roth uploaded patch set 3 10/08/21, 13:31

  7. Jochen Roth updated the commit message in patch set 4 10/08/21, 13:32

  8. core-ci voted on patch set 3 V +1 10/08/21, 13:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17819

  9. core-ci voted on patch set 4 V +1 10/08/21, 13:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17820

  10. Helmut Hummel commented on patch set 4 V -1 10/08/21, 14:30

    ImageContentObject.php:234 Reply

    The thing is, that $this->cObj->getImgResource() can still return sourceInfo from Gifbuilder, which isn't FAL, which means absRefPrefix needs to be applied there as well, similar to the code from a single image here: https://github.com/TYPO3/typo3/blob/46e8a7025a0e3d770949f02c45402179ad3beb54/typo3/sysext/frontend/Classes/ContentObject/ImageContentObject.php#L64-L66 I only overlooked the responsive rendering part in the previous patch
  11. Jochen Roth uploaded patch set 5 10/08/21, 15:08

  12. Jochen Roth uploaded patch set 6 10/08/21, 15:08

  13. core-ci voted on patch set 5 V +1 10/08/21, 15:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17828

  14. core-ci voted on patch set 6 V +1 10/08/21, 15:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17829

  15. Helmut Hummel voted on patch set 6 V +1 CR +1 10/08/21, 16:19

  16. Benni Mack voted on patch set 6 V +2 CR +2 10/08/21, 16:27

  17. Benni Mack merged patch set 7 10/08/21, 16:27

  18. Benni Mack commented on patch set 7 10/08/21, 16:27

    ImageContentObject.php:234 Reply

    Ack