Review main Merged

71511[BUGFIX] Properly set softRefParams in LinkAnalyzer

Oli Bartsch CR +2 V +2 Easy +14 −5 updated 10/09/21, 09:29

Commit message

This correctly sets "subst" as a value of the
softRefParams array. Previously "subst" was
set as key, which only worked because of a
non strict "in_array" check, which also
returned TRUE for this case, but then broke
with the refactoring in #94687.

Additionally the regular expression of the
UrlSoftReferenceParser, used to find urls
in content, also got extended in #94687.
This is now partially reset to not longer
match links in tag attributes. This otherwise
would lead to duplicate entries, since those
urls are already matched by the
TypolinkTagSoftReferenceParser.

The impact of the changed regular expression
was overlooked beforehand, due to the bug
in LinkAnalyzer.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 914

  1. Oli Bartsch uploaded patch set 1 10/08/21, 17:36

  2. core-ci voted on patch set 1 V -1 10/08/21, 17:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17833

  3. Oli Bartsch uploaded patch set 2 10/08/21, 21:19

  4. core-ci voted on patch set 2 V -1 10/08/21, 21:23 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17841

  5. Nikita Hovratov uploaded patch set 3 10/08/21, 21:28

  6. Oli Bartsch uploaded patch set 4 10/08/21, 21:31

  7. core-ci voted on patch set 3 V +1 10/08/21, 21:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17842

  8. Oli Bartsch updated the commit message in patch set 5 10/08/21, 21:48

  9. Nikita Hovratov voted on patch set 5 V +1 CR +1 10/08/21, 21:54

  10. core-ci voted on patch set 4 V +1 10/08/21, 22:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17843

  11. core-ci voted on patch set 5 V +1 10/08/21, 22:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17844

  12. Georg Ringer voted on patch set 5 V +1 CR +1 10/09/21, 07:29

  13. Oli Bartsch voted on patch set 5 V +2 CR +2 10/09/21, 09:29

  14. Oli Bartsch merged patch set 6 10/09/21, 09:29