Review main Merged

71512[BUGFIX] Move virtual storage 0 back to public path

Simon Gilli CR +2 V +2 Normal +120 −18 updated 10/12/21, 14:32

Commit message

It was a conceptual mistake to move storage 0 base path
outside the document root (public path), because this complete
compatibility layer relies on the fact that this storage
is public. Moving it outside the public path, implicitly
made this storage private, with all logical consequences like
eID public URLs. This of course isn't desired and a breaking
change of behaviour.

With moving the base path back it means, that trying to access this
BC layer with paths that are not within the public path,
will not work any more. This is fine though, because this
never worked before TYPO3 11.5 anyway.

The reason why this was made working was EXT:form, which
used the storage 0 compat layer for resolving form
definitions from extensions, which did not work, when
installing extensions into vendor folder (instead of the still
current default, where extensions are installed in public folder).

Accessing public resources from vendor installed extensions
will still work with this change, because the public asset
URL will automatically be calculated, but accessing private resources
will thrown an exception to clarify that the storage 0 compat layer
is not made to make this possible.

Also fix form framework to not rely on FAL compatibility
layer during form loading.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jochen Roth +1
    • Markus Klein +1
    • Oliver Hader +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jochen Roth +1
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 3043

Show 1018 earlier messages
  1. Simon Gilli uploaded patch set 1 10/08/21, 18:53

  2. core-ci voted on patch set 1 V -1 10/08/21, 19:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17834

  3. Simon Gilli uploaded patch set 2 10/08/21, 20:18

  4. Simon Gilli uploaded patch set 3 10/08/21, 20:19

  5. Simon Gilli uploaded patch set 4 10/08/21, 20:22

  6. core-ci voted on patch set 2 V +1 10/08/21, 20:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17837

  7. core-ci voted on patch set 3 V +1 10/08/21, 20:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17838

  8. core-ci voted on patch set 4 V +1 10/08/21, 20:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17839

  9. Simon Gilli updated the commit message in patch set 5 10/08/21, 20:54

  10. core-ci voted on patch set 5 V +1 10/08/21, 21:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17840

  11. Simon Gilli updated the commit message in patch set 6 10/08/21, 22:35

  12. core-ci voted on patch set 6 V +1 10/08/21, 22:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17847

  13. Simon Gilli uploaded patch set 7 10/08/21, 23:43

  14. core-ci voted on patch set 7 V +1 10/09/21, 00:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17853

  15. Simon Gilli uploaded patch set 8 10/09/21, 00:04

  16. Simon Gilli commented on patch set 8 10/09/21, 00:06

    This change is ready for review.
  17. core-ci voted on patch set 8 V +1 10/09/21, 00:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17854

  18. Helmut Hummel voted on patch set 8 CR -1 10/09/21, 07:35

  1. Helmut Hummel commented on patch set 8 V -1 10/09/21, 10:12

    This won't work either unless this line is touched again: https://github.com/TYPO3/typo3/blob/c746c186013c350f80c5c5b161c562ab3c95c32f/typo3/sysext/core/Classes/Resource/ResourceFactory.php#L319 to calculate paths relative to public path instead of project path

    StorageRepositoryTest.php:151

    I don't think these tests provide any value
  2. Simon Gilli commented on patch set 8 10/09/21, 11:08

    Reply

    As already said at Slack, I don't think so because the absolute filename is calculated before and it makes sure assets from extensions work for both, installations in typo3conf/ext and vendor.

    StorageRepositoryTest.php:151 Reply

    Well, this test ensures the storage 0 will stay public and this is not changed by accident. That's all.
  3. Helmut Hummel uploaded patch set 9 10/09/21, 11:45

  4. Helmut Hummel commented on patch set 9 10/09/21, 11:48

    Reply

    No, for sure. We can't change one without the other. Or it will be completely broken.
  5. Helmut Hummel commented on patch set 9 10/09/21, 11:51

    StorageRepositoryTest.php:151 Reply

    I did not change this by accident, but deliberatly. And in such case, I would have adapted these tests anyway.
  6. core-ci voted on patch set 9 V +1 10/09/21, 12:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17864

  7. Simon Gilli marked it work in progress 10/09/21, 14:43

  8. Simon Gilli commented on patch set 9 10/09/21, 14:45

    ResourceFactory.php:315

    This should be $absoluteFilePath now I guess
  9. Helmut Hummel uploaded patch set 10 10/09/21, 18:45

  10. Helmut Hummel commented on patch set 9 10/09/21, 18:45

    ResourceFactory.php:315 Reply

    Done
  11. Simon Gilli commented on patch set 10 V -1 10/09/21, 18:49

    This change is ready for review.
    on it...
  12. core-ci voted on patch set 10 V +1 10/09/21, 19:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17877

  13. Simon Gilli uploaded patch set 11 10/10/21, 00:12

  14. Simon Gilli commented on patch set 11 V -1 10/10/21, 00:14

    still on it...
  15. core-ci voted on patch set 11 V -1 10/10/21, 00:29 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17881

  16. Helmut Hummel uploaded patch set 12 10/10/21, 09:22

  17. core-ci voted on patch set 12 V -1 10/10/21, 09:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17887

  18. Helmut Hummel uploaded patch set 13 10/10/21, 09:40

  19. core-ci voted on patch set 13 V +1 10/10/21, 09:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17889

  20. Helmut Hummel voted on patch set 13 V +1 CR +1 10/11/21, 08:16

  21. Jochen Roth voted on patch set 13 V +1 CR +1 10/11/21, 09:18

  22. Markus Klein commented on patch set 13 CR +1 10/11/21, 09:51

    Thanks for your efforts, looks good to me.
  23. Andreas Kienast voted on patch set 13 V +2 CR +2 10/11/21, 09:55

  24. Andreas Kienast merged patch set 14 10/11/21, 09:55

  25. Oliver Hader voted on patch set 14 CR +1 10/12/21, 14:32