71512[BUGFIX] Move virtual storage 0 back to public path
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Jochen Roth +1
- Markus Klein +1
- Oliver Hader +1
- Helmut Hummel +1
-
Verified V +2 Done
- Andreas Kienast +2
- Jochen Roth +1
- Helmut Hummel +1
- core-ci +1 CI
Issues 1
Files 4
Review log 3043
Show 1018 earlier messages
-
Simon Gilli uploaded patch set 1 10/08/21, 18:53
-
core-ci voted on patch set 1 V -1 10/08/21, 19:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17834
-
Simon Gilli uploaded patch set 2 10/08/21, 20:18
-
Simon Gilli uploaded patch set 3 10/08/21, 20:19
-
Simon Gilli uploaded patch set 4 10/08/21, 20:22
-
core-ci voted on patch set 2 V +1 10/08/21, 20:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17837
-
core-ci voted on patch set 3 V +1 10/08/21, 20:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17838
-
core-ci voted on patch set 4 V +1 10/08/21, 20:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17839
-
Simon Gilli updated the commit message in patch set 5 10/08/21, 20:54
-
core-ci voted on patch set 5 V +1 10/08/21, 21:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17840
-
Simon Gilli updated the commit message in patch set 6 10/08/21, 22:35
-
core-ci voted on patch set 6 V +1 10/08/21, 22:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17847
-
Simon Gilli uploaded patch set 7 10/08/21, 23:43
-
core-ci voted on patch set 7 V +1 10/09/21, 00:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17853
-
Simon Gilli uploaded patch set 8 10/09/21, 00:04
-
Simon Gilli commented on patch set 8 10/09/21, 00:06
This change is ready for review. -
core-ci voted on patch set 8 V +1 10/09/21, 00:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17854
-
Helmut Hummel voted on patch set 8 CR -1 10/09/21, 07:35
-
Helmut Hummel commented on patch set 8 V -1 10/09/21, 10:12
This won't work either unless this line is touched again: https://github.com/TYPO3/typo3/blob/c746c186013c350f80c5c5b161c562ab3c95c32f/typo3/sysext/core/Classes/Resource/ResourceFactory.php#L319 to calculate paths relative to public path instead of project pathStorageRepositoryTest.php:151I don't think these tests provide any value -
Simon Gilli commented on patch set 8 10/09/21, 11:08
Reply
As already said at Slack, I don't think so because the absolute filename is calculated before and it makes sure assets from extensions work for both, installations in typo3conf/ext and vendor.StorageRepositoryTest.php:151ReplyWell, this test ensures the storage 0 will stay public and this is not changed by accident. That's all. -
Helmut Hummel uploaded patch set 9 10/09/21, 11:45
-
Helmut Hummel commented on patch set 9 10/09/21, 11:48
Reply
No, for sure. We can't change one without the other. Or it will be completely broken. -
Helmut Hummel commented on patch set 9 10/09/21, 11:51
StorageRepositoryTest.php:151ReplyI did not change this by accident, but deliberatly. And in such case, I would have adapted these tests anyway. -
core-ci voted on patch set 9 V +1 10/09/21, 12:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17864
-
Simon Gilli marked it work in progress 10/09/21, 14:43
-
Simon Gilli commented on patch set 9 10/09/21, 14:45
ResourceFactory.php:315This should be $absoluteFilePath now I guess -
Helmut Hummel uploaded patch set 10 10/09/21, 18:45
-
Helmut Hummel commented on patch set 9 10/09/21, 18:45
ResourceFactory.php:315ReplyDone -
Simon Gilli commented on patch set 10 V -1 10/09/21, 18:49
This change is ready for review.on it... -
core-ci voted on patch set 10 V +1 10/09/21, 19:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17877
-
Simon Gilli uploaded patch set 11 10/10/21, 00:12
-
Simon Gilli commented on patch set 11 V -1 10/10/21, 00:14
still on it... -
core-ci voted on patch set 11 V -1 10/10/21, 00:29 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17881
-
Helmut Hummel uploaded patch set 12 10/10/21, 09:22
-
core-ci voted on patch set 12 V -1 10/10/21, 09:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17887
-
Helmut Hummel uploaded patch set 13 10/10/21, 09:40
-
core-ci voted on patch set 13 V +1 10/10/21, 09:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17889
-
Helmut Hummel voted on patch set 13 V +1 CR +1 10/11/21, 08:16
-
Jochen Roth voted on patch set 13 V +1 CR +1 10/11/21, 09:18
-
Markus Klein commented on patch set 13 CR +1 10/11/21, 09:51
Thanks for your efforts, looks good to me. -
Andreas Kienast voted on patch set 13 V +2 CR +2 10/11/21, 09:55
-
Andreas Kienast merged patch set 14 10/11/21, 09:55
-
Oliver Hader voted on patch set 14 CR +1 10/12/21, 14:32