Review main Merged

71513[BUGFIX] Ensure routing works for request with chinese letter

Stefan Bürk CR +2 V +2 Hard +297 −2 updated 10/13/21, 19:19

Commit message

Routing for requests with chinese letters failed. As the used
symfony components internally uses rawlurldecode() on some
places, but this was not done reading from site configuration
and reparing route collection, this has been lead to 404
instead of correct page matchings.

This patch uses rawurldecode() to prepare route paths correctly
for chinese letters and introduce tests to cover these cases.

Furthermore it adds some todo's which are out of the scope
for this patch.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 812

  1. Stefan Bürk uploaded patch set 1 10/08/21, 20:12

  2. Stefan Bürk uploaded patch set 2 10/08/21, 20:17

  3. core-ci voted on patch set 1 V +1 10/08/21, 20:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17835

  4. core-ci voted on patch set 2 V +1 10/08/21, 20:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17836

  5. Stefan Bürk updated the commit message in patch set 3 10/08/21, 22:47

  6. core-ci voted on patch set 3 V +1 10/08/21, 23:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17849

  7. Georg Ringer voted on patch set 3 CR +1 10/10/21, 06:41

  8. Jochen Roth uploaded patch set 4 10/13/21, 13:13

  9. Jochen Roth commented on patch set 4 V +1 CR +1 10/13/21, 13:14

    SiteRequestTest.php:378

    Should be "chinese"

    SlugSiteRequestTest.php:554

    Should be "chinese"
  10. core-ci voted on patch set 4 V +1 10/13/21, 13:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18044

  11. Benni Mack voted on patch set 4 V +2 CR +2 10/13/21, 19:18

  12. Benni Mack merged patch set 5 10/13/21, 19:19