71513[BUGFIX] Ensure routing works for request with chinese letter
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Jochen Roth +1
-
Verified V +2 Done
- Benni Mack +2
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Routing/SiteMatcher.php+5 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/PlainScenario.yaml+8 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/SlugScenario.yaml+8 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/AbstractTestCase.php+2 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php1+117 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugLinkGeneratorTest.php+5 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestTest.php1+152 −0
Review log 812
-
Stefan Bürk uploaded patch set 1 10/08/21, 20:12
-
Stefan Bürk uploaded patch set 2 10/08/21, 20:17
-
core-ci voted on patch set 1 V +1 10/08/21, 20:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17835
-
core-ci voted on patch set 2 V +1 10/08/21, 20:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17836
-
Stefan Bürk updated the commit message in patch set 3 10/08/21, 22:47
-
core-ci voted on patch set 3 V +1 10/08/21, 23:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17849
-
Georg Ringer voted on patch set 3 CR +1 10/10/21, 06:41
-
Jochen Roth uploaded patch set 4 10/13/21, 13:13
-
Jochen Roth commented on patch set 4 V +1 CR +1 10/13/21, 13:14
SlugSiteRequestTest.php:554Should be "chinese" -
core-ci voted on patch set 4 V +1 10/13/21, 13:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18044
-
Benni Mack voted on patch set 4 V +2 CR +2 10/13/21, 19:18
-
Benni Mack merged patch set 5 10/13/21, 19:19
SiteRequestTest.php:378