Review main Merged

71514[BUGFIX] Check for complete database configuration before connecting

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 02/22/22, 20:14

Commit message

Install tool has been trying to connect to the database before
checking if a bare minimum of configuration is given to. This has
been done to decide if the database connect step needs to be shown.

Starting with php8.1 this fails hard and the step is not shown,
thus an installation cannot be finished.

This patch change the checking order and checks for the bare minimum of
configuration first, before try to connect to the database.

Build/Scripts/runTests.sh -s acceptanceInstall -p 8.1 -d sqlite
Build/Scripts/runTests.sh -s acceptanceInstall -p 8.1 -d mariadb
Build/Scripts/runTests.sh -s acceptanceInstall -p 8.1 -d mysql

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Stefan Bürk uploaded patch set 1 10/08/21, 22:20

  2. Stefan Bürk updated the commit message in patch set 2 10/08/21, 22:22

  3. core-ci voted on patch set 1 V +1 10/08/21, 22:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17845

  4. core-ci voted on patch set 2 V +1 10/08/21, 22:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17846

  5. Georg Ringer voted on patch set 2 V +1 CR +1 10/10/21, 06:41

  6. Oliver Klee voted on patch set 2 CR +1 10/10/21, 08:45

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 10/11/21, 10:00

  8. Christian Kuhn merged patch set 3 10/11/21, 10:01

  9. Stefan Bürk commented on patch set 3 02/22/22, 20:14

    Backport missing for 10.4. This would also fix following issue: https://forge.typo3.org/issues/96966