Review main Merged

71517[BUGFIX] Initialize language object in SlugServiceTest

Stefan Bürk CR +2 V +2 Easy +2 −0 updated 10/11/21, 11:32

Commit message

Tests in SlugServiceTest from ext:redirects depend on
an initialized LanguageService, which has not been done
as there are no real frontend request executed, thus
the normal FE Bootstrap was not run. This leads to
undefined index errors because $GLOBALS['LANG'] is not
initalized.

The patch initalizes the LanguageService using the
Bootstrap::initalizeLanguageObject() in the setup().

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 912

  1. Stefan Bürk uploaded patch set 1 10/09/21, 12:00

  2. Stefan Bürk updated the commit message in patch set 2 10/09/21, 12:06

  3. Oliver Klee voted on patch set 2 CR +1 10/09/21, 12:07

  4. core-ci voted on patch set 1 V +1 10/09/21, 12:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17865

  5. core-ci voted on patch set 2 V +1 10/09/21, 12:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17867

  6. Christian Kuhn uploaded patch set 3 10/11/21, 10:55

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 10/11/21, 10:55

  8. Oliver Klee voted on patch set 3 CR +1 10/11/21, 10:58

  9. core-ci voted on patch set 3 V +1 10/11/21, 11:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17910

  10. Jochen Roth voted on patch set 3 V +1 CR +1 10/11/21, 11:31

  11. Christian Kuhn voted on patch set 3 V +2 CR +2 10/11/21, 11:32

  12. Christian Kuhn merged patch set 4 10/11/21, 11:32