Review main Merged

71518[BUGFIX] Initialize backenduser for RedirectServiceTest

Stefan Bürk CR +2 V +2 Easy +6 −0 updated 10/11/21, 11:33

Commit message

RedirectsServiceTests simulate frontend requests
without executing them really, which prevents from
running through the FE Bootstrap stack, thus not all
needed stuff are setup correctly, thus throwing a
warning that $GLOBALS['BE_USER'] is not defined.

This patch initialize a backenduser for the
RedirectServiceTest to setup a correct BackendUser
object, thus mitigating this warning.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Oliver Klee +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1113

  1. Stefan Bürk uploaded patch set 1 10/09/21, 12:11

  2. core-ci voted on patch set 1 V +1 10/09/21, 12:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17868

  3. Oliver Klee voted on patch set 1 CR +1 10/09/21, 13:22

  4. Guido Schmechel commented on patch set 1 CR +1 10/09/21, 13:35

    Suggestion for commit message headline: ext.redirects -> EXT:redirects or maybe shorter? "[BUGFIX] Initialize backend user for RedirectServiceTest"
  5. Stefan Bürk updated the commit message in patch set 2 10/09/21, 13:38

  6. Stefan Bürk commented on patch set 2 10/09/21, 13:38

    Reply

    Done
  7. Guido Schmechel voted on patch set 2 CR +1 10/09/21, 13:45

  8. core-ci voted on patch set 2 V +1 10/09/21, 13:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17872

  9. Oliver Klee voted on patch set 2 CR +1 10/09/21, 14:42

  10. Christian Kuhn voted on patch set 2 V +1 CR +1 10/11/21, 10:47

  11. Jochen Roth voted on patch set 2 V +1 CR +1 10/11/21, 11:33

  12. Christian Kuhn voted on patch set 2 V +2 CR +2 10/11/21, 11:33

  13. Christian Kuhn merged patch set 3 10/11/21, 11:33