Review main Merged

71519[BUGFIX] PHP8.0 warning from ext:recycler tests

Stefan Bürk CR +2 V +2 Easy +16 −6 updated 10/11/21, 11:30

Commit message

Initializing LanguageService in $GLOBALS['LANG'] with
Bootstrap::initalizeLanguageObject() needs a proper setup
$GLOBALS['BE_USER'].

The patch moves Bootstrap::initialzeLanguageObject() from
abstract testcase to the corresponding setUp() methods
user and admin recycler tests after the corresponding
backend user is set up.

Furthermore some assertions are fine tuned to prevent
array access warnings in tests.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 811

  1. Stefan Bürk uploaded patch set 1 10/09/21, 13:01

  2. core-ci voted on patch set 1 V -1 10/09/21, 13:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17870

  3. Stefan Bürk uploaded patch set 2 10/09/21, 13:39

  4. core-ci voted on patch set 2 V +1 10/09/21, 13:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17873

  5. Christian Kuhn uploaded patch set 3 10/11/21, 10:53

  6. Christian Kuhn voted on patch set 3 V +1 CR +1 10/11/21, 10:53

  7. Nikita Hovratov voted on patch set 3 V +1 CR +1 10/11/21, 11:10

  8. core-ci voted on patch set 3 V +1 10/11/21, 11:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17909

  9. Jochen Roth voted on patch set 3 V +1 CR +1 10/11/21, 11:30

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 10/11/21, 11:30

  11. Christian Kuhn merged patch set 4 10/11/21, 11:30