Review main Merged

71520[BUGFIX] PHP8.0 warning in CleanerTask

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 10/10/21, 12:00

Commit message

CleanerTasks build a query checking if tstamp tca
config is checked. Using null coalescing operator
to sanatize access in the condition.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Stefan Bürk uploaded patch set 1 10/09/21, 13:13

  2. Oliver Klee voted on patch set 1 CR +1 10/09/21, 13:21

  3. core-ci voted on patch set 1 V +1 10/09/21, 13:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17871

  4. Guido Schmechel voted on patch set 1 CR +1 10/09/21, 13:32

  5. Oli Bartsch voted on patch set 1 V +1 CR +1 10/10/21, 10:48

  6. Georg Ringer voted on patch set 1 V +2 CR +2 10/10/21, 12:00

  7. Georg Ringer merged patch set 2 10/10/21, 12:00