Review main Merged

71522[TASK] Upgrade @types/bootstrap to 5.1.6

Nikita Hovratov CR +2 V +2 Easy +5 −9 updated 10/11/21, 18:10

Commit message

This resolves a todo in Tooltip.ts, where we've waited
for an updated types definition for bootstrap. Now
some new methods, like Tooltip.getOrCreateInstance,
are known to TypeScript and can be used, without
setting an ignore comment.

Command used:
> yarn upgrade @types/bootstrap --latest

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 45

  1. Nikita Hovratov uploaded patch set 1 10/09/21, 18:46

  2. core-ci voted on patch set 1 V +1 10/09/21, 19:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17878

  3. Wouter Wolters voted on patch set 1 V +1 CR +1 10/11/21, 17:28

  4. Benni Mack voted on patch set 1 V +2 CR +2 10/11/21, 18:10

  5. Benni Mack merged patch set 2 10/11/21, 18:10