Review main Merged

71524[TASK] Add class name to deprecated cObj for plugins message

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 10/11/21, 09:17

Commit message

Public property $cObj for plugins has been deprecated in
v11 with #94956 and setContentObjectRenderer() method has
been introduced as replacement.

If this method is missing, a deprecation message is triggered.

This patch inserts the class name of the plugin into the message,
to make it easier to determine where the new method is missing.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Stephan Großberndt +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Stefan Bürk uploaded patch set 1 10/09/21, 19:47

  2. core-ci voted on patch set 1 V +1 10/09/21, 20:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17880

  3. Oliver Klee voted on patch set 1 CR +1 10/09/21, 20:08

  4. Georg Ringer voted on patch set 1 V +1 CR +1 10/10/21, 06:31

  5. Stephan Großberndt updated the commit message in patch set 2 10/10/21, 08:15

  6. Stephan Großberndt voted on patch set 2 CR +1 10/10/21, 08:15

  7. core-ci voted on patch set 2 V +1 10/10/21, 08:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17885

  8. Oliver Klee voted on patch set 2 CR +1 10/10/21, 08:44

  9. Oli Bartsch voted on patch set 2 V +1 CR +1 10/10/21, 10:41

  10. Benni Mack voted on patch set 2 V +2 CR +2 10/11/21, 09:17

  11. Benni Mack merged patch set 3 10/11/21, 09:17