Review main Merged

71526[TASK] Set visibility of Clipboard->getLocalizations to protected

Nikita Hovratov CR +2 V +2 Easy +19 −22 updated 10/11/21, 09:16

Commit message

This resolves a todo, where a test was blocking a
method of Clipboard to be protected. The test is
now adjusted as such that it now calls a real
public method and extracts the needed
information from it.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Nikita Hovratov uploaded patch set 1 10/10/21, 14:39

  2. core-ci voted on patch set 1 V -1 10/10/21, 14:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17896

  3. Nikita Hovratov uploaded patch set 2 10/10/21, 14:49

  4. core-ci voted on patch set 2 V +1 10/10/21, 15:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17900

  5. Benni Mack voted on patch set 2 CR +1 10/10/21, 18:26

  6. Georg Ringer voted on patch set 2 V +1 CR +1 10/11/21, 05:48

  7. Jochen Roth voted on patch set 2 V +1 CR +1 10/11/21, 08:28

  8. Benni Mack voted on patch set 2 V +2 CR +2 10/11/21, 09:16

  9. Benni Mack merged patch set 3 10/11/21, 09:16