Review main Merged

71529[BUGFIX] Prevent undefined array key access in modAccess()

Oli Bartsch CR +2 V +2 Easy +12 −10 updated 10/11/21, 12:42

Commit message

This fixes a couple of undefined array key accesses
in BackendUserAuthentication->modAccess().

Besides, the code is a bit simplified and some
comments are added / fixed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Oli Bartsch uploaded patch set 1 10/11/21, 11:08

  2. core-ci voted on patch set 1 V +1 10/11/21, 11:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17912

  3. Jochen Roth voted on patch set 1 V +1 CR +1 10/11/21, 12:02

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 10/11/21, 12:02

  5. Nikita Hovratov voted on patch set 1 CR +1 10/11/21, 12:19

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 10/11/21, 12:42

  7. Oli Bartsch merged patch set 2 10/11/21, 12:42