Review main Merged

71531[BUGFIX] PHP 8.0 warnings in QueryGenerator

Christian Kuhn CR +2 V +2 Easy +19 −20 updated 10/11/21, 15:36

Commit message

Yet another series of PHP 8 stabilizations for
ext:lowlevel QueryGenerator. This time found by
functional tests when error handling in functionals
is turned off.

* Various null coalescence within class itself

* A test setup change which string_replace()'ed
  within a serialized string, which invalidates
  length specifications. Fixed by serializing
  after replace operations, instead of before.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1215

  1. Christian Kuhn uploaded patch set 1 10/11/21, 13:12

  2. Nikita Hovratov commented on patch set 1 V +1 CR +1 10/11/21, 13:24

    Nice.
  3. core-ci voted on patch set 1 V -1 10/11/21, 13:32 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17917

  4. Christian Kuhn uploaded patch set 2 10/11/21, 13:38

  5. core-ci voted on patch set 2 V +1 10/11/21, 13:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17919

  6. Stefan Bürk commented on patch set 2 V +1 CR +1 10/11/21, 13:54

    Nice.
  7. Jochen Roth voted on patch set 2 V +1 CR +1 10/11/21, 14:24

  8. Oli Bartsch commented on patch set 2 CR -1 10/11/21, 14:41

    in

    QueryGenerator.php:2484

    Why string|null? From reading, in the current state this could be string|int|float|null
  9. Christian Kuhn uploaded patch set 3 10/11/21, 15:05

  10. Christian Kuhn commented on patch set 2 10/11/21, 15:05

    Reply

    Done

    QueryGenerator.php:2484 Reply

    Done
  11. Oli Bartsch voted on patch set 3 V +1 CR +1 10/11/21, 15:16

  12. Stefan Bürk voted on patch set 3 V +1 CR +1 10/11/21, 15:21

  13. core-ci voted on patch set 3 V +1 10/11/21, 15:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17924

  14. Christian Kuhn voted on patch set 3 V +2 CR +2 10/11/21, 15:36

  15. Christian Kuhn merged patch set 4 10/11/21, 15:36