71531[BUGFIX] PHP 8.0 warnings in QueryGenerator
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1215
-
Christian Kuhn uploaded patch set 1 10/11/21, 13:12
-
Nikita Hovratov commented on patch set 1 V +1 CR +1 10/11/21, 13:24
Nice. -
core-ci voted on patch set 1 V -1 10/11/21, 13:32 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17917
-
Christian Kuhn uploaded patch set 2 10/11/21, 13:38
-
core-ci voted on patch set 2 V +1 10/11/21, 13:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17919
-
Stefan Bürk commented on patch set 2 V +1 CR +1 10/11/21, 13:54
Nice. -
Jochen Roth voted on patch set 2 V +1 CR +1 10/11/21, 14:24
-
Oli Bartsch commented on patch set 2 CR -1 10/11/21, 14:41
inQueryGenerator.php:2484Why string|null? From reading, in the current state this could be string|int|float|null -
Christian Kuhn uploaded patch set 3 10/11/21, 15:05
-
Christian Kuhn commented on patch set 2 10/11/21, 15:05
Reply
DoneQueryGenerator.php:2484ReplyDone -
Oli Bartsch voted on patch set 3 V +1 CR +1 10/11/21, 15:16
-
Stefan Bürk voted on patch set 3 V +1 CR +1 10/11/21, 15:21
-
core-ci voted on patch set 3 V +1 10/11/21, 15:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17924
-
Christian Kuhn voted on patch set 3 V +2 CR +2 10/11/21, 15:36
-
Christian Kuhn merged patch set 4 10/11/21, 15:36