Review main Merged

71534[BUGFIX] Add fallback for undefined key warning in PHP8

Jochen Roth CR +2 V +2 Easy +8 −8 updated 10/12/21, 10:00

Commit message

These warnings have been fixed by adding a proper
fallback where needed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1114

  1. Jochen Roth uploaded patch set 1 10/11/21, 16:10

  2. core-ci voted on patch set 1 V +1 10/11/21, 16:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17926

  3. Christian Kuhn updated the commit message in patch set 2 10/11/21, 16:50

  4. core-ci voted on patch set 2 V +1 10/11/21, 17:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17930

  5. Oliver Klee voted on patch set 2 CR +1 10/11/21, 17:24

  6. Oliver Hader voted on patch set 2 CR +1 10/12/21, 06:38

  7. Benni Mack commented on patch set 2 10/12/21, 08:57

    ContentObjectRenderer.php:1157

    ?? false seems more appropriate here.
  8. Jochen Roth uploaded patch set 3 10/12/21, 09:12

  9. Jochen Roth commented on patch set 3 10/12/21, 09:13

    ContentObjectRenderer.php:1157 Reply

    Done
  10. core-ci voted on patch set 3 V +1 10/12/21, 09:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17952

  11. Nikita Hovratov voted on patch set 3 CR +1 10/12/21, 09:34

  12. Benni Mack voted on patch set 3 V +1 CR +1 10/12/21, 09:35

  13. Christian Kuhn voted on patch set 3 V +2 CR +2 10/12/21, 10:00

  14. Christian Kuhn merged patch set 4 10/12/21, 10:00