71535[BUGFIX] Incomplete setup in PhpErrorCodeViewHelperTest
Commit message
Review
-
Code review CR +2 Done
- Tymoteusz Motylewski +2
- Wouter Wolters +1
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Tymoteusz Motylewski +2
- Wouter Wolters +1
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1012
-
Christian Kuhn uploaded patch set 1 10/11/21, 16:29
-
core-ci voted on patch set 1 V +1 10/11/21, 16:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17927
-
Wouter Wolters commented on patch set 1 10/11/21, 17:24
code path? instead of patch -
Christian Kuhn updated the commit message in patch set 2 10/11/21, 17:25
-
Christian Kuhn commented on patch set 2 10/11/21, 17:26
Reply
seems my fingers automatically type 'patch' over 'path' ^^ -
Wouter Wolters commented on patch set 2 V +1 CR +1 10/11/21, 17:26
Reply
with the rate you are pushing PATCHES I get that :-) -
core-ci voted on patch set 2 V +1 10/11/21, 17:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17931
-
Benni Mack voted on patch set 2 V +1 CR +1 10/11/21, 18:13
-
Stefan Bürk voted on patch set 2 V +1 CR +1 10/11/21, 18:15
-
Tymoteusz Motylewski voted on patch set 2 V +2 CR +2 10/11/21, 19:07
-
Stefan Bürk commented on patch set 2 10/11/21, 19:07
Reply
Done -
Tymoteusz Motylewski merged patch set 3 10/11/21, 19:07