Review main Merged

71535[BUGFIX] Incomplete setup in PhpErrorCodeViewHelperTest

Christian Kuhn CR +2 V +2 Easy +11 −1 updated 10/11/21, 19:07

Commit message

The install tool has a special standing due to the
FailSafeContainer. The default functional test set up
however creates a 'full' container. This triggers
a slightly different code path in ViewHelperResolver,
which we need to work around a bit.

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
    • Wouter Wolters +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • Wouter Wolters +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1012

  1. Christian Kuhn uploaded patch set 1 10/11/21, 16:29

  2. core-ci voted on patch set 1 V +1 10/11/21, 16:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17927

  3. Wouter Wolters commented on patch set 1 10/11/21, 17:24

    code path? instead of patch
  4. Christian Kuhn updated the commit message in patch set 2 10/11/21, 17:25

  5. Christian Kuhn commented on patch set 2 10/11/21, 17:26

    Reply

    seems my fingers automatically type 'patch' over 'path' ^^
  6. Wouter Wolters commented on patch set 2 V +1 CR +1 10/11/21, 17:26

    Reply

    with the rate you are pushing PATCHES I get that :-)
  7. core-ci voted on patch set 2 V +1 10/11/21, 17:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17931

  8. Benni Mack voted on patch set 2 V +1 CR +1 10/11/21, 18:13

  9. Stefan Bürk voted on patch set 2 V +1 CR +1 10/11/21, 18:15

  10. Tymoteusz Motylewski voted on patch set 2 V +2 CR +2 10/11/21, 19:07

  11. Stefan Bürk commented on patch set 2 10/11/21, 19:07

    Reply

    Done
  12. Tymoteusz Motylewski merged patch set 3 10/11/21, 19:07