Review main Abandoned

71553[TASK] Typo3 Mege

TYPO3com CR 0 V 0 Easy +7 −4 updated 10/12/21, 10:07

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 24

  1. TYPO3com uploaded patch set 1 10/12/21, 08:01

  2. core-ci voted on patch set 1 V -1 10/12/21, 08:05 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17948

  3. Christian Kuhn commented on patch set 1 10/12/21, 10:07

    I assume this patch was about fixing php 8 issues, but I think all has been handled already. I think it is safe to abandon for now.

    AbstractMenuContentObject.php:1116 Unresolved

    This has been changed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/71455 recently and should be php 8 sanitized well enough.

    DeletedRecords.php:250 Unresolved

    We won't pick this: We typically work with ' over ".
  4. Christian Kuhn abandoned the change 10/12/21, 10:07