71554[BUGFIX] Properly encode JSON when forwarding to RequireJS
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Stefan Bürk +1
- Mathias Brodala +1
-
Verified V +2 Done
- Oliver Hader +2
- core-ci +1 CI
Issues 1
Files 3
Review log 910
-
Oliver Hader uploaded patch set 1 10/12/21, 08:25
-
Mathias Brodala commented on patch set 1 10/12/21, 08:31
-
Oliver Hader commented on patch set 1 10/12/21, 08:34
GeneralUtility.php:3547ReplyI see... however, it would be misplaced in `StringUtility` as well since it handles arbitrary data (array, object, string, int, float, nullables, ...). `SerializationUtility` or `JsonSerializer` or similar would be more appropriate. -
core-ci voted on patch set 1 V +1 10/12/21, 08:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17950
-
Mathias Brodala commented on patch set 1 10/21/21, 13:58
GeneralUtility.php:3547ReplyAs discussed in Slack we don't have a perfect location for these yet. So for now this should be fine here but in the long term these should be bundled and migrated accordingly. -
Mathias Brodala voted on patch set 1 CR +1 10/21/21, 14:02
-
Stefan Bürk commented on patch set 1 CR +1 10/21/21, 14:58
Maybe I'm stupid - how can it/I verify it ? Code looks good so far. -
Oliver Hader voted on patch set 1 V +2 CR +2 10/21/21, 15:43
-
Oliver Hader merged patch set 2 10/21/21, 15:44
-
Oliver Hader commented on patch set 2 10/21/21, 18:07
Reply
e.g. with https://github.com/b13/masi
GeneralUtility.php:3547