Review main Merged

71557[BUGFIX] Fix PHP 8.0 warning in ContentObjectRenderer

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 10/12/21, 15:09

Commit message

As found by ext:fluid TypolinkViewHelperTest with
disabled error suppression, ContentObjectRenderer
does not properly check an array key access in a
helper method of typolink().

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Christian Kuhn uploaded patch set 1 10/12/21, 09:59

  2. core-ci voted on patch set 1 V +1 10/12/21, 10:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17957

  3. Nikita Hovratov commented on patch set 1 CR +1 10/12/21, 10:56

    Do you want to add the missing BE_USER for the test separately?
  4. Georg Ringer updated the commit message in patch set 2 10/12/21, 11:01

  5. Christian Kuhn commented on patch set 2 10/12/21, 11:15

    Reply

    yeah. hope that is ok ... there are some further cases where this will be needed.
  6. core-ci voted on patch set 2 V +1 10/12/21, 11:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17962

  7. Nikita Hovratov voted on patch set 2 V +1 CR +1 10/12/21, 12:10

  8. Jochen Roth voted on patch set 2 V +1 CR +1 10/12/21, 15:08

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 10/12/21, 15:09

  10. Christian Kuhn merged patch set 3 10/12/21, 15:09